275877 - Some langpacks do not install from link (javascript: unterminated string literal)

Status: RESOLVED FIXED

(www.mozilla.org :: General, defect)

Description

[gekacheka]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7.5) Gecko/20041107 Firefox/1.0
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7.5) Gecko/20041107 Firefox/1.0

Clicking on some lang packs such as 1.7.5 Spanish does nothing.

Reproducible: Always

Steps to Reproduce:
1. go to url http://www.mozilla.org/projects/l10n/mlp_status.html#moz_1.75
2. under 1.7.5, by Spanish, click the "mac/win/unix" lang pack link


Actual Results:  
Goes to head of section.

Expected Results:  
Loads the spanish langpack xpi.

Javascript console says "unterminated string literal".

Looking at source, problem looks like a javascript syntax error, there is no
close quote after .xpi before close brace.  Searching the source for ".xpi}"
shows that this occurs several places in the source, so it would be good to fix
all of them (1.8a4.es-ES.regpack.xpi, 1.8a3.es-ES.regpack.xpi,
1.7.5.cs-CZ.regpack.xpi, 1.7.5.es-ES.regpack.xpi).

Comment 1

[gekacheka]

Attachment: mlp_status.html: patch ".xpi," to ".xpi'," and ".xpi}" to ".xpi'}"

(from "edit this page" doctor)

Comment 2

[Christian :Biesinger (don't email me, ping me on IRC)]

thanks for the patch. I checked it in; the web page should be updated within 30
minutes or so.

Checking in html/projects/l10n/mlp_status.html;
/cvsroot/mozilla-org/html/projects/l10n/mlp_status.html,v  <--  mlp_status.html
new revision: 1.547; previous revision: 1.546
done