275906 - Previews page shows strings $preview_width and $preview_height

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Developer Pages, defect)

Description

[alanjstr]

At the bottom of the previews page, it doesn't have the variables for
$preview_width x $preview_height replaced.

Forgot to wrap the variables in <?php ?>

Comment 1

[alanjstr]

Attachment: wrap variables in php code

Also uses variables for min and max

Comment 2

[Wolf [:wolf]]

Comment on attachment 169503 [details] [diff] [review]
wrap variables in php code

Looks fine to me. :-)

Though I do wonder why the two form lines are being split like they are, if its
for length, then perhaps there's a better way to split them to not look so,
odd. Otherwise they should be on one line. :-)

Comment 3

[Wolf [:wolf]]

Comment on attachment 169503 [details] [diff] [review]
wrap variables in php code

+strict size requirements of <?php echo $preview_width . " x " . 
+$preview_height; ?>.<br><br> 

You don't have to echo variables outside of quotes and concat them together.
<?php echo"$preview_width x $preview_height"; ?> is valid. Not sure if one is
faster than the other though.

Comment 4

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

Checking in mozilla/webtools/update/developers/previews.php;
/cvsroot/mozilla/webtools/update/developers/previews.php,v  <--  previews.php
new revision: 1.9; previous revision: 1.8
done

Comment 5

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

On branch:
Checking in mozilla/webtools/update/developers/previews.php;
/cvsroot/mozilla/webtools/update/developers/previews.php,v  <--  previews.php
new revision: 1.8.2.1; previous revision: 1.8
done