Closed Bug 275936 Opened 20 years ago Closed 19 years ago

Indent code

Categories

(addons.mozilla.org Graveyard :: Developer Pages, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: Bugzilla-alanjstrBugs, Assigned: Bugzilla-alanjstrBugs)

Details

Attachments

(3 files, 1 obsolete file)

The code needs to be indented to be more readable.
Googling for 'Mozilla indent code' produced this page on the first 
hit: http://www.mozilla.org/hacking/mozilla-style-guide.html , which
may be relevant in relation to C++ source code.

The section on 'Naming and formatting' actually specificies a tab width
of 2 (and no tabs) presumably on the grounds of readability. This 
document is over two years old, and has probably found favour.

You may find that this bug us resolved as WORKSFORME.

I am fairly sure that patches for deviations from the specifications
in the document about are appropropriate, but speaking for myself
I don't normally fix up whitespace changes, spelling or profanity
unless I am also making a substantive change (improvement) to a file.

This is for us to indent the php code for update.mozilla.org.  In other words,
to apply the style guide to the code.  This is more of a reminder to use the
style guide as we rewrite code than something that is expected to be patched.
We'll let Zend make it pretty.  Need this before we can start patching bugs, so
I'd like it soon.
Assignee: nobody → mconnor
Target Milestone: 1.0 → 1.1
Ok, mconnor did a big checkin on trunk.  This is now open to anyone who wants to
pick a file and clean it up.
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Attached patch Root dir (obsolete) — Splinter Review
I'll take this directory by directory.	I was able to run this one through html
tidy.
Assignee: mconnor → Bugzilla-alanjstrBugs
Status: REOPENED → ASSIGNED
Attached patch Root dirSplinter Review
Attachment #172192 - Attachment is obsolete: true
Attached patch AboutSplinter Review
Attached patch PluginsSplinter Review
Used tidy
Target Milestone: 1.1 → 2.0
AMO 2.0 is pretty
Status: ASSIGNED → RESOLVED
Closed: 20 years ago19 years ago
Resolution: --- → FIXED
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: