275939 - Classification templates use wrong filtering in URLs

Status: RESOLVED FIXED

(Bugzilla :: Administration, task)

Description

[GavinS]

In urls, the classififcation code uses 'FILTER html'. It should use url_quote.

Patch in a mo....

Comment 1

[GavinS]

Attachment: Use correct filtering in urls in classification templates

It would be nice to be able to test for this sort of problem in the testing
suite, but I'm not sure if that would be practical. Thoughts...?

Comment 2

[Vlad Dascalu]

Regarding the patch:

-> Looks good, thanks!
-> I'm CCing Albert, Joel and Byron who did development and review on the bogus
code.
-> Requesting the appropiate flags for check in.

Regarding testing suite:

-> We could assume that 'FILTER html' inside the '<a ... >' HTML tag would be
bogus most of the time, but that would be a little bit of a hack.
-> In the same spirit, 'FILTER url_quote' outside '<a ... >' tags could be
assumed incorrect.
-> However there are lot of cases where these euristics would fail.
-> Probably that should be another bug.

Comment 3

[Vlad Dascalu]

The original bug implementing this feature is bug 224208 (targetted at 2.20).

Comment 4

[Gervase Markham [:gerv]]

Yes, file another bug on the testing suite changes. The best way to see would be
to implement the tests, and see what false positives they threw up and whether
it would be possible to work around them.

Gerv

Comment 5

[Vlad Dascalu]

Checking in template/en/default/admin/classifications/edit.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/classifications/edit.html.tmpl,v
 <--  edit.html.tmpl
new revision: 1.3; previous revision: 1.2
done
Checking in template/en/default/admin/classifications/new.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/classifications/new.html.tmpl,v
 <--  new.html.tmpl
new revision: 1.2; previous revision: 1.1
done
Checking in template/en/default/admin/classifications/select.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/classifications/select.html.tmpl,v
 <--  select.html.tmpl
new revision: 1.3; previous revision: 1.2
done