Attachment https://bugzilla.mozilla.org/attachment.cgi?id=163339 of bug 241203 introduces a new member mSaveHdr to the global variable messageHeaderSink (see http://lxr.mozilla.org/mozilla/source/mail/base/content/msgHdrViewOverlay.js#273 and the definition in line 459). But throughout this file, mSaveHdr is *wrongly* used as a global, i.e. as "if (mSaveHdr) ..." instead of "if (this.mSaveHdr)..." (all these uses are in member functions of messageHeaderSink). This does only work, because onStartHeaders does *create* this global in line 276! Even though this programming error is not visible (e.g. as error messages) in current builds, it may lead to future problems (and it is already striking extensions that overlay certain functions and use the *member* mSaveHdr). This programming error is both in current Mozilla nightlies and in Thunderbird 1.0 and newer.
Bah, I hate duping my bugs especially when they're *not* dupes - but bug 289952 already has a patch for both the suite and TB... *** This bug has been marked as a duplicate of 289952 ***
Status: NEW → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.