Closed
Bug 276015
Opened 20 years ago
Closed 20 years ago
GetOffsetFromView has a unused PresContext argument
Categories
(Core :: Layout, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: bernd_mozilla, Assigned: bernd_mozilla)
References
()
Details
Attachments
(1 file)
|
83.66 KB,
patch
|
dbaron
:
review+
dbaron
:
superreview+
|
Details | Diff | Splinter Review |
remove it
Assignee: nobody → bernd_mozilla
Status: NEW → ASSIGNED
Attachment #169594 -
Flags: superreview?(roc)
Attachment #169594 -
Flags: review?(roc)
I did not used all prescontext removal opportunities, once this get checked in, another round should target http://lxr.mozilla.org/seamonkey/search?string=PositionFrameView http://lxr.mozilla.org/seamonkey/search?string=HandlePress http://lxr.mozilla.org/seamonkey/search?string=GetContentAndOffsetsFromPoint http://lxr.mozilla.org/seamonkey/search?string=GetOriginToViewOffset http://lxr.mozilla.org/seamonkey/search?string=GetLastLeaf http://lxr.mozilla.org/seamonkey/search?string=TranslateEventCoords http://lxr.mozilla.org/seamonkey/search?string=GetDesiredSize http://lxr.mozilla.org/seamonkey/search?string=GetPointFromOffset
Comment on attachment 169594 [details] [diff] [review] patch >@@ -988,17 +984,17 @@ nsMenuPopupFrame::SyncViewWithFrame(nsPr >- GetRootViewForPopup(aPresContext, aFrame, PR_FALSE, &parentView); >+ GetRootViewForPopup( aFrame, PR_FALSE, &parentView); Fix odd spacing. r+sr=dbaron
Attachment #169594 -
Flags: superreview?(roc)
Attachment #169594 -
Flags: superreview+
Attachment #169594 -
Flags: review?(roc)
Attachment #169594 -
Flags: review+
|
||
Comment 4•20 years ago
|
||
(In reply to comment #2) > another round should target Bernd: Please take a look at bug 270708 and bug 244581. I don't think it's duplicate work, but it's quite close :) I'll be doing those two next week, and had planned to take care of other users of aPresContext afterwards.
fix checked in, I filed bug 276092 as a continuation
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
|
||
Updated•6 years ago
|
Product: Core → Core Graveyard
|
||
Updated•6 years ago
|
Component: Layout: Misc Code → Layout
Product: Core Graveyard → Core
You need to log in
before you can comment on or make changes to this bug.
Description
•