Closed
Bug 276136
Opened 21 years ago
Closed 21 years ago
Duplicate include in nsDataObj.cpp
Categories
(Core :: XUL, defect)
Core
XUL
Tracking
()
VERIFIED
FIXED
People
(Reporter: engel, Assigned: jag+mozilla)
Details
Attachments
(1 file)
|
923 bytes,
patch
|
deanis74
:
review+
sfraser_bugs
:
superreview+
|
Details | Diff | Splinter Review |
In widget/src/windows/nsDataObj.cpp, the headers <ole2.h>, <urlmon.h>, and
<shlobj.h> are included twice.
The duplicate includes were added in revision 1.64 by checking in a patch for
Bug 157994 (Attachment 158549 [details] [diff]),
http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&root=/cvsroot&subdir=mozilla/widget/src/windows&command=DIFF_FRAMESET&file=nsDataObj.cpp&rev2=1.64&rev1=1.63
|
Reporter | |
Comment 1•21 years ago
|
||
Attachment #169651 -
Flags: review?(dean_tessman)
Comment on attachment 169651 [details] [diff] [review]
remove duplicate include of ole2.h, urlmon.h, and shlobj.h
That sure wasn't part of the patch that I reviewed. r=me
Attachment #169651 -
Flags: review?(dean_tessman) → review+
|
|
Reporter | |
Comment 3•21 years ago
|
||
The duplicate includes were not a part of the patch. However, at the time of
the checkin, the patch failed since nsDataObj.cpp had changed in the meantime...
this required some hands-on editing where the duplicates were probably introduced.
|
|
Reporter | |
Updated•21 years ago
|
Attachment #169651 -
Flags: superreview?(sfraser_bugs)
|
||
Updated•21 years ago
|
Attachment #169651 -
Flags: superreview?(sfraser_bugs) → superreview+
|
|
Reporter | |
Comment 4•21 years ago
|
||
patch checked in by timeless on 2005-01-03 11:26
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
|
||
Comment 5•20 years ago
|
||
Verified FIXED using LXR/Bonsai:
1.67 timeless%mozdev.org 2005-01-03 11:26 Bug 276136 Duplicate include in
nsDataObj.cpp patch by Hans-A.Engel@unibas.ch r=dean_tessman sr=smfr
Status: RESOLVED → VERIFIED
|
|
Reporter | |
Updated•20 years ago
|
OS: Windows XP → All
Hardware: PC → All
You need to log in
before you can comment on or make changes to this bug.
Description
•