Closed Bug 276136 Opened 20 years ago Closed 20 years ago

Duplicate include in nsDataObj.cpp

Categories

(Core :: XUL, defect)

Product:
Core
Component:
XUL
Type:
defect
Priority:
Not set
Severity:
trivial

Tracking

()

Status:
VERIFIED FIXED

People

(Reporter: engel, Assigned: jag+mozilla)

Details

Attachments

(1 file)

remove duplicate include of ole2.h, urlmon.h, and shlobj.h
923 bytes, patch
deanis74
: review+
sfraser_bugs
: superreview+
Details | Diff | Splinter Review 
In widget/src/windows/nsDataObj.cpp, the headers <ole2.h>, <urlmon.h>, and
<shlobj.h> are included twice.

The duplicate includes were added in revision 1.64 by checking in a patch for
Bug 157994 (Attachment 158549 [details] [diff]),
http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&root=/cvsroot&subdir=mozilla/widget/src/windows&command=DIFF_FRAMESET&file=nsDataObj.cpp&rev2=1.64&rev1=1.63
Comment on attachment 169651 [details] [diff] [review]
remove duplicate include of ole2.h, urlmon.h, and shlobj.h

That sure wasn't part of the patch that I reviewed.  r=me
Attachment #169651 - Flags: review?(dean_tessman) → review+
The duplicate includes were not a part of the patch.  However, at the time of
the checkin, the patch failed since nsDataObj.cpp had changed in the meantime...
this required some hands-on editing where the duplicates were probably introduced.
Attachment #169651 - Flags: superreview?(sfraser_bugs)
Attachment #169651 - Flags: superreview?(sfraser_bugs) → superreview+
patch checked in by timeless on 2005-01-03 11:26
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Verified FIXED using LXR/Bonsai:

1.67	timeless%mozdev.org	2005-01-03 11:26	 	Bug 276136 Duplicate include in
nsDataObj.cpp patch by Hans-A.Engel@unibas.ch r=dean_tessman sr=smfr
Status: RESOLVED → VERIFIED
OS: Windows XP → All
Hardware: PC → All
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: