276147 - XUL tree column picker should not require ids on columns.

Status: RESOLVED INVALID

(Core :: XUL, defect)

Description

[bugs]

Currently for the column picker to work tree columns need to be uniquely ided. 
Because the current code uses document.getElementById(columnID) this fails when
multiple trees with the same column ids are actively displayed in a single
application.  This can happen for example if an application allows multiple
views of the same data at the same time.

Comment 1

[bugs]

Attachment: Possible solution

The attached XML file contains a possible solution.  This would replace the
current columnpicker binding.  Since each time the popup is created it creates
the column list, it is simple enough to just use a reference to the actual
column object rather than reference by id.

Comment 2

[Neil Deakin]

The tree widget was changed in bug 221619 to not require ids, so this change
isn't necessary.

Regardless, having two elements in the same window with the same id isn't valid
anyway.

Comment 3

[bugs]

(In reply to comment #2)

> Regardless, having two elements in the same window with the same id isn't valid
> anyway.
> 

This is exactly why this ticket needed to be resolved, so that a developer could
clone a tree node and not need to change the ids on the columns, instead leaving
the ids out. 
good to see it was resolved.