276243 - MoreInfo picks wrong application if not in URL

Status: VERIFIED INVALID

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[Duncan]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.5) Gecko/20041107 Firefox/1.0
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.5) Gecko/20041107 Firefox/1.0

Hi,

the SPF Extension for Thunderbird is misplaced as a Firefox extension, see:
https://addons.update.mozilla.org/extensions/moreinfo.php?id=345&vid=1051

Interestingly enough it mentions Thunderbird as a requirement but the links, and
the descriptions show it as Thunderbird.

It seems a bit shitzo though, e.g. Rate-it link:
https://addons.update.mozilla.org/extensions/moreinfo.php?application=firefox&version=1.0&os=Windows&id=345&page=opinion
will result in an error "Incopatible Extension".

The extension is not listed in the list of "ALL" Thunderbird extensions NOR in
the "All" Firefox Extensions.  So something is mixed up somewhere...  (sorry
that I can't be more specific, I don't grock your DB).

Reproducible: Always

Steps to Reproduce:
1. Traverse to extension: SPF (e.g via search):
https://addons.update.mozilla.org/extensions/moreinfo.php?id=345&vid=1051
2. Read mixed messages about Thunderbird requirement and Firefox extension
3. Click Rate-it link for fun...

Actual Results:  
Mixed up user and kaput web page.

Expected Results:  
Properly identified the extension as being Thunderbird related.

Comment 1

[alanjstr]

It says "Sender Policy Framework Extension - Firefox Extension" at the top.  

Comment 2

[alanjstr]

It is defaulting to Firefox as the application if it is not passed in.  If you
go to
https://addons.update.mozilla.org/extensions/moreinfo.php?id=345&vid=1051&application=thunderbird
then it works correctly.  This same bug probably leads to the dreaded
"Incompatible Extension or Extension No Longer Available"

Compare
https://addons.update.mozilla.org/extensions/moreinfo.php?application=thunderbird&id=71
to
https://addons.update.mozilla.org/extensions/moreinfo.php?id=71

Comment 3

[Jason Chu]

When viewing the details of an extension and then clicking on the author name,
the application is carried along in the URL (eg. thunderbird).  Then in the list
of themes and extensions, the links also inherit the application variable. 
However, if an extension is not for the application in the URL, then the link
will point to the wrong place (eg. a firefox extension will say
application=thunderbird&id=XXX).

Full example: Go to
https://addons.update.mozilla.org/extensions/moreinfo.php?id=150&application=thunderbird
to see the details of a Thunderbird extension.  Click on the author's name to
see a list of his extensions.  Then click on OpenBook, a Firefox extension.

Some ideas of what should happen:
1) While viewing the author's page, no application in the URL should show
extensions/themes for all applications.  If an application is specified, only
those extensions/themes for that application should appear.  Or the current
behavior can remain but (2) should be fixed.
2) The application in the link of the extension should contain the proper
application.  However, what is "proper" can be ambiguous when an extension is
compatible with multiple applications.

Comment 4

[alanjstr]

We really need to redo the way we pass information between pages. 
Unfortunately, this is too big of a change for 1.1.

Comment 5

[alanjstr]

Attachment: Change moreinfo to skip the application comparison

This will make moreinfo.php ignore the application name passed from the URI
when looking for versions.  I also removed the dropdowns since they didn't
help.  Either the addon/version exists, or it does not.

Comment 6

[alanjstr]

Attachment: Missed a few (and a typo)

Comment 7

[alanjstr]

Attachment: Change header

Comment 8

[alanjstr]

Comment on attachment 181673 [details] [diff] [review]
Change header

I don't know what will happen if it supports multiple applications; my dev
environment is incomplete.

Comment 9

[alanjstr]

Comment on attachment 181673 [details] [diff] [review]
Change header

I need to unbit rot this.

Comment 10

[Paul Tomlin]

Is this likely to get attention before v2 hits the shelves?

I started to look at it but it's a bit bigger than I'd originally thought.

Comment 11

[Raj Shekhar]

Is anyone working actively on this bug ?  I will try to get it done this week. 
The problem that I am facing is this is - what to do when the extension is
available for more than one application (like both mozilla and firefox) and no
application variable is passed in the url.  Which of the extensions do we show? 

This is valid for "dictionary tip" extension.  Here is the query 

mysql> SELECT  TM.Name, TV.Version, TV.MinAppVer, TV.MaxAppVer, TA.AppName,
TOS.OSName FROM `main` TM INNER JOIN version TV ON TM.ID = TV.ID INNER JOIN
applications TA ON TV.AppID = TA.AppID INNER JOIN os TOS ON TV.OSID = TOS.OSID
WHERE TM.ID = '1171' AND Type = 'E'  AND `approved` = 'YES'  ORDER BY `Name` ,
`Version` ;
+--------------------+---------+-----------+-----------+---------+--------+
| Name               | Version | MinAppVer | MaxAppVer | AppName | OSName |
+--------------------+---------+-----------+-----------+---------+--------+
| Dictionary Tooltip | 0.3     | 1.0       | 1.0+      | Firefox | ALL    |
| Dictionary Tooltip | 0.3     | 1.8       | 1.8+      | Mozilla | ALL    |
| Dictionary Tooltip | 0.4     | 1.0       | 1.0+      | Firefox | ALL    |
| Dictionary Tooltip | 0.4     | 1.0       | 1.0       | Mozilla | ALL    |
| Dictionary Tooltip | 0.4.1   | 1.0       | 1.0+      | Firefox | ALL    |
| Dictionary Tooltip | 0.4.1   | 1.8       | 1.8+      | Mozilla | ALL    |
| Dictionary Tooltip | 0.5     | 1.7       | 1.8+      | Mozilla | ALL    |
| Dictionary Tooltip | 0.5     | 1.0       | 1.4       | Firefox | ALL    |
| Dictionary Tooltip | 0.5.1   | 1.0       | 1.4       | Firefox | ALL    |
| Dictionary Tooltip | 0.5.1   | 1.7       | 1.8+      | Mozilla | ALL    |
| Dictionary Tooltip | 0.6     | 1.0       | 1.4       | Firefox | ALL    |
| Dictionary Tooltip | 0.6     | 1.7       | 1.8+      | Mozilla | ALL    |
+--------------------+---------+-----------+-----------+---------+--------+

One option is to display only the first one and show something like this
``
This extension is also available for
* Mozilla (linked with correct url (id=1171&appliation=mozilla) )
* Thunderbird  (id=1171&appliation=thunderbird) 
``

Comment 12

[Raj Shekhar]

I am taking this bug, I will try to see if I can implement this suggestion by CTho

20:07 < CTho> One option is to display only the first one and show something
like this `` This extension is also available for * Mozilla (linked
              with correct url (id=1171&appliation=mozilla) ) * Thunderbird 
(id=1171&appliation=thunderbird)
20:07 < CTho> lunatech: if you can show them the *compatible* one rather than
the first one in the DB (guess for compatibility) then i'd say go
              for it
20:32 < lunatech> CTho: but if the $application is not passed (via the url), how
will I know which one si the compatiable one :(
20:32 < CTho> lunatech: guess from the user agent
20:33 < CTho> note that that causes lots of headaches :(
20:33 < CTho> whcih is why we dont do it :(
20:33 < lunatech> CTho: ok - i can try that. another question - what if the user
is using IE ?
20:33 < CTho> lunatech: just show them the latest
20:34 < CTho> lunatech: maybe if you suspect it wont work with the current userr
agent, display a box warning the user
20:34 < CTho> "Note: this extension does not appear to be compatible with your
current browser".
20:34 < CTho> don't do that for thunderbird-only extensions though
20:41 < lunatech> CTho: cool - good idea

Comment 13

[Michael Morgan [:morgamic]]

*** Bug 315627 has been marked as a duplicate of this bug. ***

Comment 14

[Michael Morgan [:morgamic]]

*** Bug 312223 has been marked as a duplicate of this bug. ***

Comment 15

[Miguel Delapaz]

*** Bug 316432 has been marked as a duplicate of this bug. ***

Comment 16

[alanjstr]

AMO 2.0 has a similar problem.  I did a search for OS Integration themes linked off of the Pinball page.  It took me to public/htdocs/search.php?cat=61 which assumes I'm using Firefox.  Except it shows me Phoenity for Thunderbird.  Clicking the link to take me to the theme shows the Firefox logo at the top.

Comment 17

[alanjstr]

*** Bug 299794 has been marked as a duplicate of this bug. ***

Comment 18

[Michael Morgan [:morgamic]]

This is mostly fixed in v2.0 now, but some caveats still apply because of user-agent parsing in combination with caching.  See bug 332818 for more info on the remaining issues.