Fix indescribable addressbook code

RESOLVED FIXED

Status

MailNews Core
Backend
RESOLVED FIXED
13 years ago
9 years ago

People

(Reporter: neil@parkwaycc.co.uk, Assigned: neil@parkwaycc.co.uk)

Tracking

(Depends on: 1 bug)

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

13 years ago
In bug 44494 someone added a parameter to ExportAddressBook so that they could
pass it to a file picker. They decided to use a parameter of type
nsIDOMWindowInternal, convert it to a script global object, get the doc shell
from that, and get an nsIDOMWindow from the doc shell. This sequence is somewhat
circumlocutive, as the same object that implements nsIDOMWindowInternal also
implements nsIDOMWindow, particularly since one indirectly inherits from the
other. However there is no reason not to pass an nsIDOMWindow directly.
(Assignee)

Comment 1

13 years ago
Created attachment 169725 [details] [diff] [review]
Proposed patch
Assignee: sspitzer → neil.parkwaycc.co.uk
Status: NEW → ASSIGNED
Attachment #169725 - Flags: superreview?(bienvenu)
Attachment #169725 - Flags: review?(bienvenu)

Updated

13 years ago
Attachment #169725 - Flags: superreview?(bienvenu)
Attachment #169725 - Flags: superreview+
Attachment #169725 - Flags: review?(bienvenu)
Attachment #169725 - Flags: review+
(Assignee)

Comment 2

13 years ago
Fix checked in.
Status: ASSIGNED → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → FIXED
Product: Core → MailNews Core
You need to log in before you can comment on or make changes to this bug.