Closed
Bug 276246
Opened 20 years ago
Closed 20 years ago
Fix indescribable addressbook code
Categories
(MailNews Core :: Backend, defect)
MailNews Core
Backend
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: neil, Assigned: neil)
References
(Depends on 1 open bug)
Details
Attachments
(1 file)
|
4.03 KB,
patch
|
Bienvenu
:
review+
Bienvenu
:
superreview+
|
Details | Diff | Splinter Review |
In bug 44494 someone added a parameter to ExportAddressBook so that they could pass it to a file picker. They decided to use a parameter of type nsIDOMWindowInternal, convert it to a script global object, get the doc shell from that, and get an nsIDOMWindow from the doc shell. This sequence is somewhat circumlocutive, as the same object that implements nsIDOMWindowInternal also implements nsIDOMWindow, particularly since one indirectly inherits from the other. However there is no reason not to pass an nsIDOMWindow directly.
|
Assignee | |
Comment 1•20 years ago
|
||
Assignee: sspitzer → neil.parkwaycc.co.uk
Status: NEW → ASSIGNED
Attachment #169725 -
Flags: superreview?(bienvenu)
Attachment #169725 -
Flags: review?(bienvenu)
|
||
Updated•20 years ago
|
Attachment #169725 -
Flags: superreview?(bienvenu)
Attachment #169725 -
Flags: superreview+
Attachment #169725 -
Flags: review?(bienvenu)
Attachment #169725 -
Flags: review+
|
|
Assignee | |
Comment 2•20 years ago
|
||
Fix checked in.
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
|
||
Updated•16 years ago
|
Product: Core → MailNews Core
You need to log in
before you can comment on or make changes to this bug.
Description
•