276281 - FTP protocol handler unblocks wrong port

Status: RESOLVED INVALID

(Core Graveyard :: Networking: FTP, defect)

Description

[Dan Mellem]

The FTP Protocol Handler contains:

242 NS_IMETHODIMP 
243 nsFtpProtocolHandler::AllowPort(PRInt32 port, const char *scheme, PRBool
*_retval)
244 {
245     *_retval = (port == 21 || port == 22);
246     return NS_OK;
247 }

However, FTP doesn't use port 22 (SSH), it uses 20 (ftp-data) and 21 (ftp).

Is this correct?

Comment 1

[Christian :Biesinger (don't email me, ping me on IRC)]

well, this was added in bug 218510, apparently quite intentionally

Comment 2

[Christian :Biesinger (don't email me, ping me on IRC)]

er, oops, I meant bug 147496

Comment 3

[Bradley Baetz (:bbaetz)]

We don't support non-passive FTP, so port 20 is irrelevent.

Is port 22 even a globally-blocked port anymore? I thought we got rid of the
binary-protocol ones?

Comment 4

[Dan Mellem]

Well, bug 147496 seems to be an odd request to me, but I guess there isn't an
FTP alternative port such as 8008 is for HTTP.

It looks like 22 is still blocked by default.
http://lxr.mozilla.org/seamonkey/source/netwerk/base/src/nsIOService.cpp#86

I guess technically this bug is correct, the wrong port is unblocked, but I'd
guess it's WONTFIX since there's no significant reason to undo bug 147496.
Should I resolve this as INVALID?