276283 - Comparing number with hash leaves users unable to cancel their flag requests

Status: RESOLVED FIXED

(Bugzilla :: Creating/Changing Bugs, defect)

Description

[Vlad Dascalu]

Users can't cancel their flag requests if granting is restricted to a specific
group because the code in Flag.pm checking for the right permissions is bogus:

        next if (($status eq "X") && ($user->id eq $flag->{setter}));

should be:

        next if (($status eq "X") && ($user->id eq $flag->{setter}->id));

Problem reproduced on b.m.o., landfill and localhost install. The replacement
fixes the issue on my localhost install.

Comment 1

[Vlad Dascalu]

Attachment: patch v1

Comment 2

[Frédéric Buclin]

Sorry, you are right! It should be $flag->{setter}->id . I missed that point
when testing my patch in bug 180879. I hope this is the first and last bug about
that topic. :(

Adding myk to the CC list as he reviewed my patch.

Comment 3

[Frédéric Buclin]

Comment on attachment 169756 [details] [diff] [review]
patch v1

justdave said I could review this simple patch.

r=LpSolit

Comment 4

[Frédéric Buclin]

This is a really annoying problem which should land asap.

Comment 5

[Vlad Dascalu]

Checking in Bugzilla/Flag.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Flag.pm,v  <--  Flag.pm
new revision: 1.25; previous revision: 1.24
done

Comment 6

[Max Kanat-Alexander]

*** Bug 276917 has been marked as a duplicate of this bug. ***

Comment 7

[Dave Miller [:justdave]]

the patch for this on b.m.o was effectively replaced by the patch to bug 288603,
which changes the same line. (removing applied to b.m.o tag)