276291 - VersionCheck.php returning broken RDF for updates and maxVersion checks

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[Rui Afonso]

When trying to install the Mouse Gestures extension on FireFox 1.0 I'm getting a
dialog box with the following text:
- begin of quote
Mouse Gestures 1.0 could not be installed because it is not compatible with this
version of FireFox.
(Mouse Gestures 1.0 will only work with FireFox versions from 0.8 to 0.10)" 
- end of quote
The extension link is:
"http://ftp.mozilla.org/pub/mozilla.org/extensions/mouse_gestures/mouse_gestures-1.0-fx+mz+tb.xpi"

Take good notice of the 0.10 version. Easy bug :)

Hope that helps

Comment 1

[Rui Afonso]

Attachment: Error dialog box

Comment 2

[Phil Ringnalda (:philor)]

Must be missing a main.type in the db, because the return from version checking
gives

<RDF:Description about="urn:mozilla::{FFA36170-80B1-4535-B0E3-A4569E497DD0}">

with just :: where it should be :extension:

Comment 3

[Phil Ringnalda (:philor)]

No, on second look VersionCheck.php must be broken: everything I could find by
looking for things old enough to probably need to look for a higher maxVersion
fails the same way, with defective RDF:

Web Developer 0.8 {c45c406e-ab73-11d8-be73-000a95be3b12}
Magpie 3.1.2 {03786077-1aa1-45a6-81cf-da5b82b29919}
Image Zoom 0.1.7 {1A2D0EC4-75F5-4c91-89C4-3656F6E44B68}
Paste Quote 0.3 {1C7CCF7A-ECB8-4CE5-B5D1-A4FA477A7242}

All have urn:mozilla:: in RDF that would otherwise say they are okay for 1.0.

Comment 4

[alanjstr]

We lost "main.type AS exttype" from the SELECT statement.  Easy fix.  Patch
coming up.
http://lxr.mozilla.org/mozilla/source/webtools/update/update/VersionCheck.php#216 

Comment 5

[alanjstr]

Attachment: Adds exttype back to the select statement.

Comment 6

[alanjstr]

*** Bug 276346 has been marked as a duplicate of this bug. ***

Comment 7

[Jens Bannmann]

Not restricted to version checks - extension update silently fails, too.

Comment 8

[Christian :Biesinger (don't email me, ping me on IRC)]

Checking in webtools/update/update/VersionCheck.php;
/cvsroot/mozilla/webtools/update/update/VersionCheck.php,v  <--  VersionCheck.php
new revision: 1.4; previous revision: 1.3
done

Comment 9

[Michael Morgan [:morgamic]]

AMO BUGSPAM FOR COMPONENT MOVE AND DELETE (FILTER ME)