276292 - Create separate files for SQL

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Developer Pages, defect)

Description

[alanjstr]

To reduce the number of times code is repeated, we should have a separate file
with the SQL statements.  Basically, you pass in variables to a function call,
and it returns a recordset.  This would be similar to stored procedures.  

An example:
showlist, moreinfo, rss, and another file or two need a list of authors given an
item ID. 

We should create separate files for SELECT, INSERT, UPDATE, and DELETEs so that
the end-user site doesn't even have a chance of exposing anything dangerous.

Comment 1

[alanjstr]

This sounds very good.

PEAR :: DB_QueryTool

http://opensource.visionp.biz/index.php?id=78

Comment 2

[Raj Shekhar]

Good idea in theory, but I doubt if it will work in practise.  Frankly, I have
never seen any project which keeps all its sql in one file. 

One thing that I have seen is that some projects keep their sqls at the top of
the file in a hash.  For example -
$sql['extension']='select blah1,blha2 from table blah';
$sql['theme'] = 'select from ---';
and so on.

I am not sure if this method has any advantage over what is being done currently. 

Comment 3

[alanjstr]

Resolved by addons/shared/lib/ class files