276306 - Unused variable `nsresult ret' in nsMsgGroupThread::AddChildFromGroupView

Status: RESOLVED WORKSFORME

(MailNews Core :: Backend, defect)

Description

[timeless]

8.	mailnews/base/src/nsMsgGroupThread.cpp:202 (See build log excerpt)
	Unused variable `nsresult ret'
	

200 nsresult nsMsgGroupThread::AddChildFromGroupView(nsIMsgDBHdr *child,
nsMsgDBView *view)
201 {
202   nsresult ret = NS_OK;
203   PRUint32 newHdrFlags = 0;
204   PRUint32 msgDate;

Comment 1

[timeless]

9.	mailnews/base/src/nsMsgGroupThread.cpp:206 (See build log excerpt)
	Unused variable `PRBool parentKeyNeedsSetting'
	

204 PRUint32 msgDate;
205 nsMsgKey newHdrKey = 0;
206 PRBool parentKeyNeedsSetting = PR_TRUE;
207 PRBool hdrAddedToThread = PR_FALSE;

10.	mailnews/base/src/nsMsgGroupThread.cpp:207 (See build log excerpt)
	Unused variable `PRBool hdrAddedToThread'
	

205 nsMsgKey newHdrKey = 0;
206 PRBool parentKeyNeedsSetting = PR_TRUE;
207 PRBool hdrAddedToThread = PR_FALSE;
208 
209 child->GetFlags(&newHdrFlags);

11.	mailnews/base/src/nsMsgGroupThread.cpp:217 (See build log excerpt)
	Unused variable `PRUint32 childIndex'
	

215 child->AndFlags(~(MSG_FLAG_WATCHED | MSG_FLAG_IGNORED), &newHdrFlags);
216 PRUint32 numChildren;
217 PRUint32 childIndex = 0;
218 
219 // get the num children before we add the new header.

Comment 2

[(not reading, please use [e-mail] instead)]

sorry for the spam.  making bugzilla reflect reality as I'm not working on these bugs.  filter on FOOBARCHEESE to remove these in bulk.

Comment 3

[Mark Banner (:standard8)]

I've just been through the unused variable and they are either all used or no longer in the code.