Closed
Bug 276318
Opened 20 years ago
Closed 20 years ago
Context menu search does not obey "browser.tabs.loadInBackground" pref (tabs are not selected)
Categories
(Firefox :: Search, defect)
Firefox
Search
Tracking
()
VERIFIED
FIXED
Firefox1.5
People
(Reporter: Gavin, Assigned: Gavin)
References
Details
Attachments
(1 file, 1 obsolete file)
947 bytes,
patch
|
mconnor
:
review+
|
Details | Diff | Splinter Review |
The pref is supposed to be checked at:
http://lxr.mozilla.org/mozilla/source/browser/base/content/browser.js#2409
but the pref variable is not defined. Patch coming up.
Assignee | ||
Comment 1•20 years ago
|
||
Attachment #169800 -
Flags: review?(mconnor)
Assignee | ||
Updated•20 years ago
|
Status: NEW → ASSIGNED
Comment 2•20 years ago
|
||
(In reply to comment #0)
> but the pref variable is not defined.
It seems that gPrefService is defined as expected.
http://lxr.mozilla.org/mozilla/source/browser/base/content/browser.js#696
Assignee | ||
Comment 3•20 years ago
|
||
Major oopsies :). That was a little presumptuous of me wasn't it? Thanks to
Callek and Torisugari for pointing out my mistake.
Attachment #169800 -
Attachment is obsolete: true
Attachment #169801 -
Flags: review?(mconnor)
Assignee | ||
Updated•20 years ago
|
Attachment #169800 -
Flags: review?(mconnor)
Updated•20 years ago
|
Attachment #169801 -
Flags: review?(mconnor) → review+
Assignee | ||
Updated•20 years ago
|
Whiteboard: [patch-r+] [checkin needed]
Assignee | ||
Updated•20 years ago
|
Target Milestone: --- → Firefox1.1
Comment 4•20 years ago
|
||
Checking in browser/base/content/browser.js;
/cvsroot/mozilla/browser/base/content/browser.js,v <-- browser.js
new revision: 1.375; previous revision: 1.374
done
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Whiteboard: [patch-r+] [checkin needed]
Assignee | ||
Updated•20 years ago
|
Status: RESOLVED → VERIFIED
Assignee | ||
Comment 5•20 years ago
|
||
*** Bug 251777 has been marked as a duplicate of this bug. ***
You need to log in
before you can comment on or make changes to this bug.
Description
•