276360 - Don't use non-ASCII wide character constants

Status: RESOLVED FIXED

(Core Graveyard :: XForms, defect)

Description

[Simon Montagu :smontagu]

Wide-character constants outside the ASCII range (e.g. L'\x00c0') are
non-portable and shouldn't be used: their value is dependent on the effective
locale at compilation time. On my locale (Hebrew) nsXFormsXPathXMLUtil.cpp won't
even compile, because L'\x00ff' is an undefined character.

See 'man mbrtowc'.

Comment 1

[Simon Montagu :smontagu]

Attachment: Patch

The diff is hard to read, but it's just the result of a regexp-replace of
L'\\x\(....\)'
by
0x\1

Comment 2

[Darin Fisher]

Comment on attachment 169833 [details] [diff] [review]
Patch

yeah, anyways the "L" prefix is not very portable.  thanks for creating this
patch simon!

sr=darin

Comment 3

[Peter Van der Beken [:peterv]]

These arrays aren't necessary anyway, there are two functions (IsXMLLetter and
IsXMLNCNameChar) on nsIParserService that can be used instead.

Comment 4

[Allan Beaufour]

(In reply to comment #3)
> These arrays aren't necessary anyway, there are two functions (IsXMLLetter and
> IsXMLNCNameChar) on nsIParserService that can be used instead.

Check. All the nsXFormsXPath*-files should be integrated with Transformiix and
other existing code, it was just to make things work. Bug 265212 will track that
work.

Comment 5

[aaronr]

Comment on attachment 169833 [details] [diff] [review]
Patch

Thanks for the patch.
r=aaronr

Comment 6

[Simon Montagu :smontagu]

THanks for reviews, patch checked in.