276361 - Major BView leak in nsDrawingSurfaceBeOS

Status: RESOLVED FIXED

(Core Graveyard :: GFX: BeOS, defect)

Description

[Simon]

When an offscreen drawing surface is created, it uses a BBitmap with an attached
BView to enable the BBitmap to be drawn to.

However in the nsDrawingSurface destructor, the BView is removed from the bitmap
but not deleted. After a while (especially in firefox - the transparency in the
loading icon uses lots of drawing surfaces), BeOS hits a hard limit around 32000
BViews per application and crashes with the debugger message "The token space is
full. I will crash now."

According to the BeBook, the BBitmap destructor takes care of removing and
freeing and child views, so all that is required to fix the leak is to remove
the line that removes the view from the BBitmap before calling delete on the
BBitmap.

A simple patch is on the way.

Comment 1

[Simon]

Attachment: Simple fix (diff -up4)

This simple patch fixes the leak.

BeOS-only code in a BeOS-only folder.

If someone could review and check in that would be great.

Comment 2

[Simon]

Comment on attachment 169836 [details] [diff] [review]
Simple fix (diff -up4)

Requesting review.

Comment 3

[Sergei Dolgov]

Comment on attachment 169836 [details] [diff] [review]
Simple fix (diff -up4)

r=sergei_d

no need for sr,
pure port-only patch

Comment 4

[Simon]

Can we get this checked in?

Then the next thing to do is to get an nsDrawingSurface::Lock() implementation
into the tree, but that's in another bug.

Comment 5

[Niels Reedijk]

Checked in by timeless on the first of Januari (thanks!)