276373 - [BeOS] SpecialSystemDirectory::GetSpecialSystemDirectory don't work correctly for BeOS_DesktopDirectory (and cleanup)

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[tqh]

We should not call find_directory for B_DESKTOP_DIRECTORY with 0 (reverts to
/boot) as volume, we should check on which volume the user has it's files.

Comment 1

[tqh]

Attachment: removes a lot of duplicate code and gets the users volume when getting Desktop

Comment 2

[Niels Reedijk]

This patch seems to provoke some problems on my system. First of all, on the
first launch after applying, all my toolbar icons are gonde. On the second
launch, only the back and next button are missing, and the next launch they're
all there. But also going to the options... dialog crashes FF. I don't know to
what extend you can reproduce this behaviour. I didn't start with a clean
profile though (perhaps that's it?) Anyway, not including this patch in build d2.

Comment 3

[Niels Reedijk]

Attachment: Updated to HEAD - still the same patch by tqh

Comment 4

[tqh]

Hmm, that sounds strange. The only real difference is that we get which volume
to look at for Desktop, and that path doesn't have a added '/' at the end. I
don't remember why I removed the '/' but I did check it with printf's and it
worked ok here. Maybe there are some differences compared to AVIARY. I'll look
into it.

Comment 5

[tqh]

Attachment: Updated add slash if needed again

Comment 6

[tqh]

Comment on attachment 170658 [details] [diff] [review]
Updated add slash if needed again

slash, not backslash.
r?

Comment 7

[Sergei Dolgov]

tqh, somebody noticed in bezilla blog (probably Andrew Bachman?) that using
BPath may be more elegant, as it auto-normalizes paths with /./././.  :)
Did you notice that comment?

Comment 8

[tqh]

Well I just did it like that as we already had it as an char array, so I saw no
need to introduce a BPath as well.

Comment 9

[Sergei Dolgov]

Comment on attachment 170658 [details] [diff] [review]
Updated add slash if needed again

r=sergei_d

Comment 10

[tqh]

Comment on attachment 170658 [details] [diff] [review]
Updated add slash if needed again

sr?
(I also need someone to commit this in case of success.)

Comment 11

[Doug Turner (:dougt)]

Comment on attachment 170658 [details] [diff] [review]
Updated add slash if needed again

could strlen(path) ever return 0 and result still be B_OK?

if no, sr=dougt

Comment 12

[tqh]

It should not, but might as well check for it.

Comment 13

[tqh]

Attachment: Fail on zero len path

Only change is 'if(len == 0) return NS_ERROR_FAILURE;' line.

Comment 14

[tqh]

Comment on attachment 171438 [details] [diff] [review]
Fail on zero len path

Only change is 'if(len == 0) return NS_ERROR_FAILURE;' line. But asking for sr
to be safe.

Comment 15

[Doug Turner (:dougt)]

Comment on attachment 171438 [details] [diff] [review]
Fail on zero len path

Your surname isn't capitalized -- not sure if that is intentional.

Seams like you have a 12 char indentation in that function -- not sure if that
matches the rest of the style in this file.

Fix up the whitespace, and sr=dougt

Comment 16

[tqh]

Attachment: Better formatting

I assume there is no need for sr, same patch different formatting.
Changed spacing, and formatting to match rest of the code.

Comment 17

[Niels Reedijk]

Checked in by timeless