276423 - VersionCheck does not exclude items

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[alanjstr]

Items that are disabled or not approved should not appear.

Comment 1

[alanjstr]

Attachment: Make sure it is approved

Since jensb is around, jensb gets to do the review.

Comment 2

[Jens Bannmann]

Comment on attachment 169873 [details] [diff] [review]
Make sure it is approved

> $where = " WHERE main.guid = '" . $reqItemGuid . "' 
>              AND applications.guid = '" . $reqTargetAppGuid . "'
>-             AND (version.OSID = 1 OR version.OSID = " . $osid . ")";
>+             AND (version.OSID = 1 OR version.OSID = " . $osid . 
>+             AND version.approved = 'YES')";

PHP Syntax error, the string is terminated before $osid. Besides, you changed
the logic, the braces should only surround the OSID checks. How about:

>+             AND (version.OSID = 1 OR version.OSID = " . $osid . ")
>+             AND version.approved = 'YES'";

Comment 3

[alanjstr]

Attachment: move that parens where it belongs

Comment 4

[Jens Bannmann]

Comment on attachment 169875 [details] [diff] [review]
move that parens where it belongs

sorry, there is one superfluous brace left after 'YES'.

+ with this change.

Comment 5

[alanjstr]

Attachment: one ... more ... time

Comment 6

[Wolf [:wolf]]

Comment on attachment 169877 [details] [diff] [review]
one ... more ... time

Works for me. :-)

Comment 7

[Wolf [:wolf]]

Checked in..

cbeard: this needs to land on the live site.

Comment 8

[alanjstr]

*** Bug 276526 has been marked as a duplicate of this bug. ***

Comment 9

[alanjstr]

*** Bug 276731 has been marked as a duplicate of this bug. ***

Comment 10

[alanjstr]

*** Bug 276859 has been marked as a duplicate of this bug. ***

Comment 11

[Michael Morgan [:morgamic]]

AMO BUGSPAM FOR COMPONENT MOVE AND DELETE (FILTER ME)