276444 - xbl:inherits should have feedback

Status: RESOLVED INVALID

(Core :: XBL, enhancement)

Description

[alexander :surkov (:asurkov)]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8a5) Gecko/20041122
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8a5) Gecko/20041122

I set on anonymous node 'xbl:inherits' attribute. Attribute value of anonymous
node is changed when corresponding attribute of binding is changed. I think it's
needed to realize 'inherits' attribute feedback. In other words when I change
attribute value of anonymous node then attribute value of binding should be
changed also.

This feature helps to keep attribute value of binding in correct state.

Reproducible: Always

Steps to Reproduce:

Comment 1

[alexander :surkov (:asurkov)]

In instance html:input inherits 'value' attribute from textbox binding. When I
type text into html:input then 'value' attribute is changed but 'value'
attribute of textbox isn't changed. Therefore when I try
textbox.getAttribute('value') then I get wrong value of textbox attribute.

Comment 2

[Martijn Wargers (dead)]

(In reply to comment #1)
> When I type text into html:input then 'value' attribute is changed 
That's not true. The DOM HTML .value attribute is not the same as the HTML
attribute 'value' in HTML. When you type text in an html textbox, the dom .value
is changed, but not the html attribute "value". This is not a bug, this is by
design (and is actually according to the specs.

Comment 3

[alexander :surkov (:asurkov)]

Ok. I agree my previous example is not correct.

You can try checkbox instead of html:input.

//test.xml
<binding id="binding1">
<content>
	<xul:checkbox xbl:inherits="checked"/>
</content>
</binding>

//test.xul
<checkbox/>
<button label="test1"
oncommand="alert(this.previousSibling.getAttribute('checked'))"/>

<binding1/>
<button label="test2"
oncommand="alert(this.previousSibling.getAttribute('checked'))"/>

Attribute 'checked' of checkbox will be changed but attribute 'checked' of
binding1 will not be changed after clicks on checkboxes. This example shows what
I suppose.

Comment 4

[Boris Zbarsky [:bzbarsky]]

This is invalid.  Multiple child nodes can inherit a value from the binding, and
may want to change it independently of each other (and of the binding).

Comment 5

[alexander :surkov (:asurkov)]

You're right: maybe sometimes xbl:inherits without feedback is useful. But
sometimes such possibility is needed. When I should provide such feedback myself
then I should write routine code. If such feature will be presented then it will
save much time of developer. How do you think is it needed to add new attribute
(xbl:feedbackinherits) or something else?

Comment 6

[Boris Zbarsky [:bzbarsky]]

I'd bring that up in the relevant newsgroup...

Comment 7

[alexander :surkov (:asurkov)]

Please give me newsgroup url to watch the discussion.

Comment 8

[Boris Zbarsky [:bzbarsky]]

netscape.public.mozilla.xbl newsgroup (news.mozilla.org server).

Comment 9

[alexander :surkov (:asurkov)]

corresponding topic of newsgroup
http://groups-beta.google.com/group/netscape.public.mozilla.xbl/browse_thread/thread/e77dce6086c2d6d9/80bc2bf5caebf537#80bc2bf5caebf537