276473 - Show_activity merges incorrectly sometimes changesets into one changeset

Status: RESOLVED FIXED

(Bugzilla :: Creating/Changing Bugs, defect)

Description

[Vlad Dascalu]

Show_activity merges incorrectly sometimes changesets into one changeset. Dave
said that we should display seconds as well in the activity log, which should
prevent incorrect merge of multiple changesets into one changeset, when they are
performed in the same minute.

Comment 1

[Vlad Dascalu]

Attachment: patch v1

Glob: ok, I know this is not a one-liner, but I had to change the time filter
too in order to allow it to display the additional seconds field fetched by
SQL.

We don't fill the $sec variable if we receive a MySQL timestamp because we
don't want to change the current behaviour. If seconds aren't specified, $sec
will be undef and the old code will go as well.

Comment 2

[:glob ✱]

Comment on attachment 169909 [details] [diff] [review]
patch v1

sorry, the change to format_time causes 007util.t to fail

Comment 3

[Vlad Dascalu]

Attachment: patch v2

sorry, this should fix it.

Comment 4

[GavinS]

*** Bug 238749 has been marked as a duplicate of this bug. ***

Comment 5

[:glob ✱]

Comment on attachment 169915 [details] [diff] [review]
patch v2

r=glob

Comment 6

[Dave Miller [:justdave]]

wouldn't it make sense to make test 7 test it both ways, since you're supporting
both, instead of changing the test to only test the full syntax?

Comment 7

[Vlad Dascalu]

Attachment: v3

Comment 8

[Vlad Dascalu]

v3: compared to v2, this adds testing both ways by introducing an additional
test per comment #6.

Comment 9

[Vlad Dascalu]

Byron, you're still around? v3 still needs review. :)

Comment 10

[:glob ✱]

Comment on attachment 169965 [details] [diff] [review]
v3

r=glob

Comment 11

[Shane H. W. Travis]

2.18:
Checking in CGI.pl;
/cvsroot/mozilla/webtools/bugzilla/CGI.pl,v  <--  CGI.pl
new revision: 1.211.2.8; previous revision: 1.211.2.7
done
Checking in Bugzilla/Util.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Util.pm,v  <--  Util.pm
new revision: 1.12.2.2; previous revision: 1.12.2.1
done
Checking in t/007util.t;
/cvsroot/mozilla/webtools/bugzilla/t/007util.t,v  <--  007util.t
new revision: 1.4.2.1; previous revision: 1.4
done

Tip:
Checking in CGI.pl;
/cvsroot/mozilla/webtools/bugzilla/CGI.pl,v  <--  CGI.pl
new revision: 1.222; previous revision: 1.221
done
Checking in Bugzilla/Util.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Util.pm,v  <--  Util.pm
new revision: 1.14; previous revision: 1.13
done
Checking in t/007util.t;
/cvsroot/mozilla/webtools/bugzilla/t/007util.t,v  <--  007util.t
new revision: 1.5; previous revision: 1.4
done

Comment 12

[Frédéric Buclin]

*** Bug 309164 has been marked as a duplicate of this bug. ***