276478 - ChatZilla doesn't connect/start in Mozilla 1.0.2

Status: RESOLVED FIXED

(Other Applications Graveyard :: ChatZilla, defect)

Description

[James Ross]

It seems that in the 0.9.63 cycle (probably when adding DCC support) two
critical lines were removed from StreamListener.prototype.onDataAvailable. These
two lines are needed for Mozilla versions that HAS_NSPR_EVENTQ, which definately
includes Mozilla 1.0.2 (which I'm using with the fix now), and may include 1.4.

Comment 1

[James Ross]

Attachment: Create the scriptable input stream for async reads

This fixes the offending code, however I've found that while 0.9.66e runs in
Mozilla 1.0.2 and connects with this change, 0.9.67 (trunck CVS) fails with an
error on startup.

Comment 2

[James Ross]

IIRC (Venkman hung while I was debugging it), it is a problem in getFileFromURLSpec:
  http://lxr.mozilla.org/mozilla/source/extensions/irc/js/lib/utils.js#905

It seems |Components.interfaces.nsIFileProtocolHandler| is null. So the QI fails.

Comment 3

[James Ross]

Hmm, now it works. Odd... it didn't work as Administrator, but does work as a
Power User. This could take some investigating...

It looks like getFileFromURLSpec is still on the IO Service in Mozilla 1.0.2. I
guess the same fix as is in getURLSpecFromFile would work...

Comment 4

[James Ross]

Attachment: Fix async reads, and getFileFromURLSpec

This fixes ChatZilla 0.9.67/trunk to run in Mozilla 1.0.2 as any user.

Comment 5

[Robert Ginda]

Comment on attachment 169928 [details] [diff] [review]
Fix async reads, and getFileFromURLSpec

r=rginda

Comment 6

[James Ross]

Checked in --> FIXED.