276495 - browser.link.open_newwindow.restriction opens popups with toolbars and menubars in new windows

Status: RESOLVED INVALID

(Firefox :: Tabbed Browser, defect)

Description

[Yuan Qi]

I like this options and have set it to 2 to allow webapps to work correctly.
However, right now this option also allows popups with toolbar and menubar to
open in new window, while most user expect these windows to be opened in tabs.

To test this bug, set the pref to 2. Open this page
(http://www.download.com/Mozilla-Firefox/3000-2356_4-10335582.html?tag=lst-0-1)
in firefox and click on the "Mozilla" link under the Publisher column

Comment 1

[atzaus]

I can also confirm this bug.. links with target="_blank" open correctly but JS
links like window.open() etc are opening in new windows

Comment 2

[Pavel Penaz]

I am seeing the same thing on the testcase provided.

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b) Gecko/20050117 Firefox/1.0+

Comment 3

[Chris Blore]

Confirmed under Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b)
Gecko/20050117 Firefox/1.0+

Could you change the Version to 'trunk' so this can be confirmed as a valid bug
report?

Comment 4

[Steve England [:stevee]]

re: The js thing as mentioned in Comment #1.

If this is the same problem as observed when using Gmail (clicking on links in
your  email open in a new window rather than a new tab) then:

2005-01-11-08-trunk works as expected (opens gmail links in new tabs)
2005-01-12-07-trunk does not work as expected (spawns new window)

re: Comment #0
link http://www.download.com/Mozilla-Firefox/3000-2356_4-10335582.html?tag=lst-0-1
with browser.link.open_newwindow.restriction=2 this behavies the same for me in
Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7.5) Gecko/20041107
Firefox/1.0 and in tonight's nightly.

Comment 5

[José Jeria]

is bug 278143 related?

Comment 6

[Pavel Penaz]

I do not think these two bugs are related. This bug depends on having set
browser.link.open_newwindow.restriction=2 and bug 278143 does not.

Comment 7

[Peter van der Woude [:Peter6]]

->New
since this was Unco branch I'll change version ->Unspecified
sererity->Major (normal is just too little)

Comment 8

[Pavel Penaz]

This bug exists in 20050101 Firefox/1.0+. Unfortunately I do not have an older
build to determine the exact regression window.

Comment 9

[atzaus]

I think this is back to normal on the 17th Feb 2005 build. window.open() and
other JS links are opening in same/new tabs (according to your pref). The
testcase provided is a sized window and I think its ok for it to open in a new
window because sized windows might be small or big and a 20*20 window wouldn't
look good on a 1600*1200 res in a tab.

Comment 10

[:Gavin Sharp [email: [e-mail]]]

browser.link.open_newwindow.restriction to "2" means "don't divert window.open with features". Comment #4 was likely bug 278143.