276522 - setting icalComponent on an event shouldn't update lst-modified

Status: RESOLVED FIXED

(Calendar :: Internal Components, defect)

Description

[Michiel van Leeuwen (email: mvl+moz@)]

When setting icalComponent on an event, the last-modified field gets updated to
the current time. They should not change, since parsing doesn't actually change
anything.

Comment 1

[Michiel van Leeuwen (email: mvl+moz@)]

Attachment: patch

Comment 2

[Michiel van Leeuwen (email: mvl+moz@)]

related: attaching an event to a calendar (after parsing it) also updates
lastmodified. (due to the general makeMemberAttr().) I think it shouldn't.

Comment 3

[Michiel van Leeuwen (email: mvl+moz@)]

Attachment: patch v2

Updated patch. Also makes sure last-modified isn't updated when setting parent.

Comment 4

[Michiel van Leeuwen (email: mvl+moz@)]

Comment on attachment 169977 [details] [diff] [review]
patch v2

>Index: base/src/calEvent.js
>     clone: function () {
>+        m.mDirty = false;

Ignore that one, it isn't needed.

Comment 5

[Michiel van Leeuwen (email: mvl+moz@)]

Attachment: additional patch

This is also needed to keep lastmodified. MAke sure to read the date before
cloning, and copy dirty info.

Comment 6

[Michiel van Leeuwen (email: mvl+moz@)]

patches checked in.