Open Bug 276593 Opened 20 years ago Updated 4 years ago

cmd_paragraphState vs setParagraphMode w.r.t. focus change

Categories

(Core :: DOM: Editor, defect, P5)

defect

Tracking

()

People

(Reporter: eyalroz1, Unassigned)

Details

I don't think calling

doStatefulCommand('cmd_paragraphState', /*whatever*/);

should change the focus to the message body. That is a side-effect not at all
implied by the command name.

So I tried using editor.setParagraphMode() instead, which worked, but didn't set
the paragraph mode string in the drop-down list until I changed the focus to the
message body.
Hmmm... it seems that at endTransaction it says that 

"beginUpdate must be called before endTransaction is called."

were you referring to the lack of beginUpdate() calls? Because We have lots of
other code which does updates within begin/endTransaction() and does not call
beginUpdate, yet it works. As it should, I believe. Either way, if beginUpdate()
is needed, then the logStringMessage can't give the updated value until the
entire operation has been performed... right?
Uh, sorry, commented in wrong bug.
So calling editor.setParagraphMode() doesn't affect focus but doStatefulCommand
does?  Hmmmm.... did you find where the "focus()" call is?  I'm curious.
> did you find where the "focus()" call is?  I'm curious.

No... lots of spaghetti code in the editor :-(
Summary: cmd_paragraphState, setParagraphMode issues → cmd_paragraphState vs setParagraphMode w.r.t. focus change
QA Contact: bugzilla → editor
Assignee: mozeditor → nobody

Bulk-downgrade of unassigned, >=3 years untouched DOM/Storage bug's priority.

If you have reason to believe this is wrong, please write a comment and ni :jstutte.

Severity: normal → S4
Priority: -- → P5
You need to log in before you can comment on or make changes to this bug.