276634 - Devguide update reflecting change in DB.pm deprecated routines.

Status: RESOLVED FIXED

(Bugzilla :: bugzilla.org, defect)

Description

[Kevin Benton]

Current developer's guide still suggests using deprecated routines.  This is
inappropriate.

Comment 1

[Kevin Benton]

Attachment: Diff to developer's guide web page.

Comment 2

[Vlad Dascalu]

Comment on attachment 170003 [details] [diff] [review]
Diff to developer's guide web page.

+    <p><code class="perl">$Query="SELECT field1 FROM table WHERE field2 = " .
SqlQuote($variable);</code></p>

I'd prefer to have a space before and after the = sign. Also, $Query should
probably start with a lowercase q.

+  my $dbh = Bugzilla->dbh; # Connects if not already connected.<br>
+ 
&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&
nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;# Also handles
db, user, password...<br>
+  my $sth = $dbh->prepare("SELECT foo, bar FROM bath WHERE log = ?");<br>

I hate having this little hack with &nbsp;. If <code> doesn't show spaces,
maybe <pre> will.

Anyway, in this case, I'd prefer to have the comment and the line of code on
different lines, especially since the code is followed up on the next line.

Comment 3

[Vlad Dascalu]

s/the code is followed up/the comment is followed up/

(in my previous comment)

Comment 4

[Kevin Benton]

Attachment: Updated devguide update reflecting change in DB.pm deprecated routines.

Made the changes you requested, Vlad.

Comment 5

[Kevin Benton]

Attachment: One more change I missed - $Query -> $query

Comment 6

[Kevin Benton]

Comment on attachment 171572 [details] [diff] [review]
Updated devguide update reflecting change in DB.pm deprecated routines.

Left out a change.

Comment 7

[Kevin Benton]

Comment on attachment 171576 [details] [diff] [review]
One more change I missed - $Query -> $query

One more change...

Comment 8

[Kevin Benton]

Attachment: Last change I hope - added missing noun

Comment 9

[Shane H. W. Travis]

Comment on attachment 173883 [details] [diff] [review]
Last change I hope - added missing noun

Not last change, sorry...

We also talked about how this (pseudo)code was incorrect;

while ($result=$sth->fetchrow_array()) {

That needs to be fixed up to get an r+ from me. 


+<p>For more information, see the DBI pod or see the embedded documentation in
Bugzilla/DB.pm.</p>

Nit: *consult* the DBI pod, or see the ...

(Having 'see the' twice in a row grates on me, but it's only nit-level.)

Comment 10

[Kevin Benton]

Attachment: Re-applied changes including bug fix in code.

Comment 11

[Kevin Benton]

Attachment: Re-applied changes including bug fix in code - right file this time. Can anything else go wrong? Sheesh!

Comment 12

[Kevin Benton]

Looks like patch was applied by Travis.  Thanks :)