276637 - Textarea tags can be left open indefinitely with <! or <!-- in content

Status: RESOLVED FIXED

(Core :: DOM: HTML Parser, defect)

Description

[Ben]

[quote]
<TEXTAREA>This is some text<!--</TEXTAREA>

<BR><BR>This is some more text.
[/quote]

The second sentence will display in the textarea box, including all HTML between.

IE only escapes a <TEXTAREA> with a </textarea> from what I can tell...
commentry shouldn't escape it, I believe.

Comment 1

[Blake Kaplan (:mrbkap) (inactive)]

Confirming and taking. I was worried about this when I wrote the function. In
fact, you *can* comment out the </textarea> in IE (I'll attach a testcase in a
bit). What's happening here is that IE is very strict about what comments it
accepts as comments in <textarea> and <title>. In quirks mode, we accept just
about anything. The easy fix is to consume comments in <textarea> and <title> in
standards mode no matter what mode the document is in.

Comment 2

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: quirks mode testcase

Comment 3

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: standards mode testcase

Note that in this testcase, our rendering matches IE's (I bet there are some
edge cases that break us even in standards mode, but I don't think I care about
those).

Comment 4

[Bastiaan Jacques]

Attachment: don't parse comments in quirks mode

<mrbkap> In quirks mode, we consume too many things as comments, so we should
either modify aFlags to be in standards mode, or just pass in special flags
instead of aFlags.

Comment 5

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 175754 [details] [diff] [review]
don't parse comments in quirks mode

Thanks a lot! r=mrbkap

Comment 6

[Blake Kaplan (:mrbkap) (inactive)]

Assigning to Bastiaan, since this is his patch.

Comment 7

[Blake Kaplan (:mrbkap) (inactive)]

And marking FIXED, since this was checked in.