276661 - The cancel button is lacked in the import completion dialog of the address

Status: RESOLVED FIXED

(Thunderbird :: Address Book, defect)

Description

[Hiro]

The cancellation button is lacked in the import completion dialog of the 
address. 

It is likely to depend on bug233781. 

Reproducible: Always
Steps to Reproduce:
1.The text file is chosen with import in the address. 

Actual Results:
The cancel button is lacked in the dialog of the import completion. 

Expected Results:
The dialog of the import completion is correctly displayed. 

thunderbird 1.0 release
Mac OS X 10.3.7

Comment 1

[Hiro]

Attachment: screen shot of "import completion"

Comment 2

[Gervase Markham [:gerv]]

This is an automated message, with ID "auto-resolve01".

This bug has had no comments for a long time. Statistically, we have found that
bug reports that have not been confirmed by a second user after three months are
highly unlikely to be the source of a fix to the code.

While your input is very important to us, our resources are limited and so we
are asking for your help in focussing our efforts. If you can still reproduce
this problem in the latest version of the product (see below for how to obtain a
copy) or, for feature requests, if it's not present in the latest version and
you still believe we should implement it, please visit the URL of this bug
(given at the top of this mail) and add a comment to that effect, giving more
reproduction information if you have it.

If it is not a problem any longer, you need take no action. If this bug is not
changed in any way in the next two weeks, it will be automatically resolved.
Thank you for your help in this matter.

The latest beta releases can be obtained from:
Firefox:     http://www.mozilla.org/projects/firefox/
Thunderbird: http://www.mozilla.org/products/thunderbird/releases/1.5beta1.html
Seamonkey:   http://www.mozilla.org/projects/seamonkey/

Comment 3

[Gervase Markham [:gerv]]

This bug has been automatically resolved after a period of inactivity (see above
comment). If anyone thinks this is incorrect, they should feel free to reopen it.

Comment 4

[Hiro]

It still reproduces. 

Mac OS X 10.3.9
version 2 alpha 1 (20060902)

Comment 5

[Hiro]

Width is specified directly in the following parts. 
This of each platform/L10N should be able to be specified with importDialog.dtd. 

http://lxr.mozilla.org/mozilla1.8/source/mailnews/import/resources/content/importDialog.xul#53

 50 <window xmlns:rdf="http://www.w3.org/1999/02/22-rdf-syntax-ns#"
 51         xmlns="http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul"
 52         onload="OnLoadImportDialog()"
 53         style="width: 40em;"
 54         title="&importDialog.windowTitle;">

Comment 6

[Hiro]

Attachment: Proposal patch

Comment 7

[Hiro]

Attachment: update patch

Comment 8

[Scott MacGregor]

I see this on my Mac too. Thanks for making this patch.

Comment 9

[Scott MacGregor]

Comment on attachment 242103 [details] [diff] [review]
update patch

we need to change this too:

http://lxr.mozilla.org/mozilla/source/mail/locales/en-US/chrome/messenger/importDialog.dtd

and we don't need to run the xul pre-processor on importDialog.dtd, so this change should be removed too:

-    locale/en-US/messenger/importDialog.dtd                             (import/resources/locale/en-us/importDialog.dtd)
+*   locale/en-US/messenger/importDialog.dtd    

The rest of the patch looks good!

Comment 10

[Hiro]

Attachment: patch-v02

Comment#9 was reflected.

Comment 11

[Scott MacGregor]

Comment on attachment 242113 [details] [diff] [review]
patch-v02

almost there.

I meant:

importDialog.dtd does not need to be pre-processed since it doesn't have an ifdef. 

importDialog.xul still needs to go through the xul pre-processor since that file has the 
#ifdef XP_MACOSX.

You still need the jar.mn changes for importDialog.xul.

Comment 12

[Hiro]

Attachment: patch03

oops...
jar.mn was forgotten.

Comment 13

[Scott MacGregor]

Comment on attachment 242169 [details] [diff] [review]
patch03

awesome, thanks so much for the patch.

Comment 14

[Scott MacGregor]

If you ask nicely, gavin might even check this in for you :).

Comment 15

[Hiro]

(In reply to comment #14)
> If you ask nicely, gavin might even check this in for you :).
> 

Scott-san,
Thank you for a quick review. 

Gavin-san,
Could you do the check-in of this patch?

Comment 16

[:Gavin Sharp [email: [e-mail]]]

Yeah, I'll check this in either tomorrow or Monday.

Comment 17

[:Gavin Sharp [email: [e-mail]]]

mozilla/mail/base/jar.mn 	1.84.2.10
mozilla/mailnews/jar.mn 	1.99.2.12
mozilla/mailnews/import/resources/locale/en-us/importDialog.dtd 	1.7.28.1
mozilla/mail/locales/en-US/chrome/messenger/importDialog.dtd 	1.3.4.1
mozilla/mailnews/import/resources/content/importDialog.xul 	1.23.8.1

mozilla/mail/locales/en-US/chrome/messenger/importDialog.dtd 	1.6
mozilla/mailnews/import/resources/content/importDialog.xul 	1.25
mozilla/mail/base/jar.mn 	1.94
mozilla/mailnews/jar.mn 	1.116
mozilla/mailnews/import/resources/locale/en-us/importDialog.dtd 	1.9

Comment 19

[Marcia Knous [:marcia]]

verified fixed on the 1.8 branch using the Tbird cand build, version 2.0.0.0 (20070326). I tested on on Intel Mac running 10.4.9. The cancel button shows clearly. My only nit is it a magnitude larger than the other two buttons. Adding verified keyword.