nsHistoryLoadListener.cpp in source tree, but unused

RESOLVED FIXED

Status

--
minor
RESOLVED FIXED
14 years ago
5 months ago

People

(Reporter: crispin, Unassigned)

Tracking

Trunk
x86
Linux

Firefox Tracking Flags

(Not tracked)

Details

While trying to work out if nsIBrowserHistory::HidePage was ever actually used,
I noticed that both:

http://lxr.mozilla.org/seamonkey/source/xpfe/components/history/src/nsHistoryLoadListener.cpp
http://lxr.mozilla.org/seamonkey/source/toolkit/components/history/src/nsHistoryLoadListener.cpp

are not used, they are not compiled (missing from the Makefile.in) and in fact
haven't been updated to the new nsIBrowserHistory API (nsIURI rather than strings).

Possibly they should be removed, and perhaps the nsIBrowserHistory::HidePage()
function as well.

Comment 1

14 years ago
r=me for removing the files. IIRC there were external embedders who were using
hidePage, but I don't remember why.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Removing xpfe/components/history/src/nsHistoryLoadListener.cpp;
/cvsroot/mozilla/xpfe/components/history/src/nsHistoryLoadListener.cpp,v  <-- 
nsHistoryLoadListener.cpp
new revision: delete; previous revision: 1.8
done
Removing toolkit/components/history/src/nsHistoryLoadListener.cpp;
/cvsroot/mozilla/toolkit/components/history/src/nsHistoryLoadListener.cpp,v  <--
 nsHistoryLoadListener.cpp
new revision: delete; previous revision: 1.3
done
Status: NEW → RESOLVED
Last Resolved: 14 years ago
Resolution: --- → FIXED

Updated

5 months ago
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.