276731 - VersionCheck throws mySQL error

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Administration, defect)

Description

[Nickolay_Ponomarev]

Comment 1

[alanjstr]

How about some details?  Is it that users are being pointed to update-beta? 
Then this is a dupe of another bug.  Are you requesting that it be updated?

Comment 2

[Nickolay_Ponomarev]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.5) Gecko/20041107 Firefox/1.0

Mouse Gestures 1.0 listed at:
https://addons.update.mozilla.org/extensions/moreinfo.php?application=firefox&id=39&vid=810

- is said to be compatible with Firefox 1.0, but when you try to install you get
a message that it's incompatible with Firefox 1.0 and only with 0.8-0.10, as its
install.rdf file indicates.

Since I think that firefox checks u.m.o for version upgrades [and MG doesn't
have updateURL in its install.rdf], u.m.o must be not sending correct info to it.

Related: 275911

Comment 3

[Nickolay_Ponomarev]

Alan, sorry that was an accidental <Enter> while typing summary :) I still can't
get used to this keyboard :)

Comment 4

[alanjstr]

*** This bug has been marked as a duplicate of 276423 ***

Comment 5

[Nickolay_Ponomarev]

That bug is about *exclusion* of items, after that is fixed, I'll be unable to
install/upgrade to "unapproved" items, as far as I understand - VersionCheck.php
seems to be responsible for giving update.rdf to Firefox.

In this bug the Mouse Gestures extension is already approved (unless you have
another bug about showing unapproved items in web listings), but I still cannot
install it. Limiting the set of available-to-install extensions won't help.

The dupe is at least unobvious. Could you explain what's happening?
And please also resolve bug 275911 as it is similar to this.

Comment 6

[alanjstr]

From install.rdf
    <em:targetApplication> <!-- Firefox -->
      <Description>
        <em:id>{ec8030f7-c20a-464f-9b0e-13a3a9e97384}</em:id>
        <em:minVersion>0.8</em:minVersion>
        <em:maxVersion>0.10</em:maxVersion>
      </Description>

If the update service is not performing correctly (or cannot be reached),
Firefox will go by what is in the install.rdf.

Comment 7

[alanjstr]

*** Bug 276742 has been marked as a duplicate of this bug. ***

Comment 8

[Nickolay_Ponomarev]

I get a lot of errors instead of well-formed RDF file at
https://update.mozilla.org/update/VersionCheck.php?reqVersion=1&id={FFA36170-80B1-4535-B0E3-A4569E497DD0}&version=1.0&maxAppVersion=0.10&appID={ec8030f7-c20a-464f-9b0e-13a3a9e97384}&appVersion=1.0
- which I believe to be the URL firefox uses to check for maxversion bumps. The
errors are like this one (I don't know much about PHP/MySQL, sorry):

<b>Warning</b>:  mysql_real_escape_string(): Can't connect to local MySQL server
through socket '/var/lib/mysql/mysql.sock' (2) in
<b>/opt/update/update/VersionCheck.php</b> on line <b>128</b><br />
<br />
<b>Warning</b>:  mysql_real_escape_string(): A link to the server could not be
established in <b>/opt/update/update/VersionCheck.php</b> on line <b>128</b><br />

Comment 9

[Nickolay_Ponomarev]

*** Bug 275911 has been marked as a duplicate of this bug. ***

Comment 10

[Nickolay_Ponomarev]

A friend of mine says he thinks there should be a connection to mysql for a
mysql_real_escape_string call to succeed. It works for him even without that
though :-/

Raising severity, as it doesn't work for any of extensions I tried and stops
people from installing extensions with low maxversions in their XPI.

Comment 11

[alanjstr]

Attachment: Move SQL connection above call to above mysql_real_escape_string

Comment 12

[alanjstr]

fix applied by kveton.  VersionCheck is back up.  Leaving open until fix checked
into cvs.

Comment 13

[Nickolay_Ponomarev]

Fixed the problem here. Thanks for a quick fix!

Comment 14

[alanjstr]

R=kveton, since he applied it to the server.

Comment 15

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

Checking in mozilla/webtools/update/update/VersionCheck.php;
/cvsroot/mozilla/webtools/update/update/VersionCheck.php,v  <--  VersionCheck.php
new revision: 1.6; previous revision: 1.5
done

Comment 16

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

(In reply to comment #15)
> Checking in mozilla/webtools/update/update/VersionCheck.php;
> /cvsroot/mozilla/webtools/update/update/VersionCheck.php,v  <--  VersionCheck.php
> new revision: 1.6; previous revision: 1.5
> done

and on MOZILLA_UPDATE_1_0_BRANCH:

Checking in mozilla/webtools/update/update/VersionCheck.php;
/cvsroot/mozilla/webtools/update/update/VersionCheck.php,v  <--  VersionCheck.php
new revision: 1.5.2.1; previous revision: 1.5
done