Closed Bug 276764 Opened 20 years ago Closed 20 years ago

In <commands.js> and <prefs.js>, 3 nits/fixes

Categories

(Other Applications :: ChatZilla, defect)

Product:
Other Applications
Component:
ChatZilla
Type:
defect
Priority:
Not set
Severity:
trivial

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
mozilla1.8beta5

People

(Reporter: sgautherie, Assigned: sgautherie)

Details

(Whiteboard: [cz-0.9.68])

Attachments

(2 obsolete files) 

[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8a5) Gecko/20041122] (release) (W98SE)

I found them, based on v1.8a5 warnings, then some more after Trunk file updates.
Assignee: rginda → gautheri
Target Milestone: --- → mozilla1.8alpha6
Attached patch (Av1) "3 fixes" (obsolete) — — Splinter Review 
*|var i|: redeclaration fix.
*|var user|: better location.
 *|e.nicknameList[i]|: I guess the second one was a copy+paste error.
*|return match;|: merging 3 into 1.

Could you review/check in this patch ? Thanks.
Attachment #170084 - Flags: review?(samuel)
Depends on: 240114, 255081, 269633
Status: NEW → ASSIGNED
Flags: blocking1.8a6?
No longer depends on: 240114, 255081, 269633
Flags: blocking1.8a6?
Comment on attachment 170084 [details] [diff] [review]
(Av1) "3 fixes"

The last else needs brackets around it though. (coding style)
Attachment #170084 - Flags: review?(samuel) → review+
Av1a, with comment 2 suggestion(s).

Keeping:
{{
(Av1) "3 fixes" 	 patch		2005-01-02 09:27 PST	2.83 KB        
samuel: review+
}}

Samuel:
Can you check it in on my behalf ? Thanks.
Attachment #170084 - Attachment is obsolete: true
Attachment #170104 - Flags: review+
Checked in --> FIXED.
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Attachment #170104 - Attachment description: (Av1a) "3 fixes" → (Av1a) "3 fixes" [Checked in: Comment 4]
Attachment #170104 - Attachment is obsolete: true
Target Milestone: mozilla1.8alpha6 → mozilla1.8beta
Whiteboard: [cz-0.9.68]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: