276792 - VersionCheck should use common DB config

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Administration, defect)

Description

[alanjstr]

Instead of having the dbconfig at the top, the service should use the common set
of data cleanup for $_GET and $_POST and conneciton info for dbconfig.

Comment 1

[Wolf [:wolf]]

VersionCheck is not integrated with the rest of the code.. Its mostly
intentional that way, as there's nothing requiring aus.mozilla.org (or any
versionCheck instance) from being on the same hardware as an Update/Addons instance.

Comment 2

[alanjstr]

It uses the same database.  Changing the config for one means having to change
the config for the other.  The sysadmins agreed with this.

Comment 3

[Wolf [:wolf]]

Then why was that not in Comment #0? :-) Seriously, a bug should be readable
enough for *all* information to be present in it without having to lurk around
IRC and in private conversations etc. 

Comment 4

[Colin Ogilvie [:cso]]

Attachment: Patch v1

Patch v1.

Use the include file, and since it defines a connection, remove the connection
stuff from VersionCheck.php

Comment 5

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

Trunk:
Checking in mozilla/webtools/update/update/VersionCheck.php;
/cvsroot/mozilla/webtools/update/update/VersionCheck.php,v  <--  VersionCheck.php
new revision: 1.7; previous revision: 1.6
done

Branch:
Checking in mozilla/webtools/update/update/VersionCheck.php;
/cvsroot/mozilla/webtools/update/update/VersionCheck.php,v  <--  VersionCheck.ph
p
new revision: 1.5.2.2; previous revision: 1.5.2.1
done