276797 - Embedded mp3 won't be transmitted to Mozplugger

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[Eric Brasseur]

Two loudspeaker icons on the page
http://www.ikzoekeenartiest.nl/lyric.php?HitsID=4967&ArtistNameID=1776 . When
clicking on them a window pops up and a mp3 play should start. Nothing happens.
This is the embed tag:

<embed src="http://www.janvis.nl/sp/mp3/danzelpumpitup.mp3" width="238"
height="46" autostart="true" lang="nl"
pluginspage="http://www.microsoft.com/Windows/Downloads/Contents/MediaPlayer/"
border="0" classid="CLSID:6BF52A52-394A-11d3-B153-00C04F79FAA6"></embed>

I pasted the tag in a custom Web page. Just remove the
classid="CLSID:6BF52A52-394A-11d3-B153-00C04F79FAA6" and everything's fine. I
suppose this embed tag is misconstructed, anyway Mozilla had a way to know
what to do since the file extension .mp3 is available.

I was using Mozplugger 1.5.2 and 1.7.0 on Mozilla 1.7.5. No problems on other
Web pages or loading local mp3 files in Mozilla. No mp3 Mimetypes defined
elsewhere in Mozilla.

Problem first posted on Mozplugger site as bug 8673. Got this feedback from
Louis Bavoil:

I could reproduce the bug with Mozilla 1.7.3 and Firefox 1.0. Unfortunately, it
cannot be fixed in Mozplugger because Mozilla/Firefox does not call the plug-in
on this page. This bug should be reported to bugzilla.mozilla.org.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Having a classid like that means an activex plugin for <object>, but maybe we
should ignore it for <embed>?

Comment 2

[Doron Rosenberg (IBM)]

cc:jst, last known soul to touch plugins :)

I'm guessing the code that is used to skip <object classid=""/> is run on embed
tags as well.  We should be ignoring classid on embed tags though.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Attachment: So like this?

This ignores classid on applet and embed.

Comment 4

[Johnny Stenback (:jst)]

Comment on attachment 172735 [details] [diff] [review]
So like this?

Yeah, makes sense. r+sr=jst

Comment 5

[Boris Zbarsky [:bzbarsky]]

Fixed