276807 - add DumpJSValue helper function for debugging

Status: RESOLVED FIXED

(Core :: XPConnect, enhancement)

Description

[Christian :Biesinger (don't email me, ping me on IRC)]

I have a patch to add a DumpJSValue function for easy printing of the value of a
jsval. since it seems generally useful, I think it'd be good to check it in.

Comment 1

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: patch

Comment 2

[Brendan Eich [:brendan]]

Comment on attachment 170115 [details] [diff] [review]
patch

Test JSVAL_IS_NULL before JSVAL_IS_OBJECT (or put the IS_NULL test inside the
IS_OBJECT case), because typeof null == "object" (ancient botch, codified in
ECMA and in SpiderMonkey).

/be

Comment 3

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: patch v2

Comment 4

[Brendan Eich [:brendan]]

Comment on attachment 170181 [details] [diff] [review]
patch v2

The printf should use null, not NULL -- the reserved id in JS is null (as in
Java).

With that, sr=me.

/be

Comment 5

[David Bradley]

Comment on attachment 170181 [details] [diff] [review]
patch v2

r=dbradley

If you think of it to keep with local style, strike the space between if and
the first paren "if("

Should be a handy diagnostic function, I know I've run across plenty of cases
where it would have been useful.

Comment 6

[Christian :Biesinger (don't email me, ping me on IRC)]

checked in with those two changes

Checking in js/src/xpconnect/src/nsXPConnect.cpp;
/cvsroot/mozilla/js/src/xpconnect/src/nsXPConnect.cpp,v  <--  nsXPConnect.cpp
new revision: 1.71; previous revision: 1.70
done