276838 - Eliminate use of $::unconfirmedstate

Status: RESOLVED FIXED

(Bugzilla :: Bugzilla-General, enhancement)

Description

[Max Kanat-Alexander]

The $::unconfirmedstate variable should either be in Bugzilla::Config or
Bugzilla::Constants. I think it makes the most sense inside of
Bugzilla::Constants. (Right now it's in globals.pl, so it must go somewhere else.)

Comment 1

[Bradley Baetz (:bbaetz)]

No, it should go away. We don't have $::duplicatestate....

If it does go anywhere, it and all the code that uses it should go into Bug.pm.

I was at one point trying to avoid just moving code out of globals.pl - it
should instead be fixed/modernised/objectised/etc before moving into modules.

Comment 2

[Max Kanat-Alexander]

I think that the re-architecting is more urgent than the code modernization. 

That is, the code modernization may take years, but we can do the re-arch right now.

Comment 3

[Max Kanat-Alexander]

Also, I think it's an OK idea to have UNCONFIRMED_STATE -- I think eventually it
will help with custom statuses.

Comment 4

[Max Kanat-Alexander]

Attachment: Patch against the tip

This patch just does a straight move of the var from one place to the other,
and makes all the necessary code changes. It's pretty straightforward.

We can consider bbaetz's comment above, too.

Comment 5

[Max Kanat-Alexander]

Actually, thinking about it more, I agree with bbaetz. There are many places
that we use a raw "UNCONFIRMED," now. We should just switch to always using that.

Comment 6

[Max Kanat-Alexander]

The change, will, of course, need to be relnoted, for anybody who's customized
the name of the "UNCONFIRMED" state. (Which is probably not too many people,
since the change would have also required changing anywhere that we already use
"UNCONFIRMED" directly.)

Comment 7

[Max Kanat-Alexander]

Attachment: Eliminate $::unconfirmedstate

OK, this patch gets *rid* of $::unconfirmedstate.

I'm not going to obsolete the other patch. If for some reason we decide that we
want to keep $::unconfirmedstate, and just move it instead, we can use the
patch above instead of this one.

Comment 8

[Vlad Dascalu]

Comment on attachment 170120 [details] [diff] [review]
Patch against the tip

Yeap, mkanat and bbaetz are right, UNCONFIRMED_STATE should be hard-coded to
"UNCONFIRMED" until we provide generic status support.

Comment 9

[Marc Schumann [:Wurblzap]]

Comment on attachment 170120 [details] [diff] [review]
Patch against the tip

Obsoleting patch as per comment 8.

Comment 10

[Marc Schumann [:Wurblzap]]

Comment on attachment 172777 [details] [diff] [review]
Eliminate $::unconfirmedstate

This doesn't apply any more... I'm ready to carry $::unconfirmedstate on a new
patch to its grave, though.

Comment 11

[Max Kanat-Alexander]

Attachment: Version 2 (Applies to current tip)

OK, here's a patch that applies to the current tip.

Comment 12

[Shane H. W. Travis]

Checking in CGI.pl;
/cvsroot/mozilla/webtools/bugzilla/CGI.pl,v  <--  CGI.pl
new revision: 1.226; previous revision: 1.225
done
Checking in buglist.cgi;
/cvsroot/mozilla/webtools/bugzilla/buglist.cgi,v  <--  buglist.cgi
new revision: 1.277; previous revision: 1.276
done
Checking in editproducts.cgi;
/cvsroot/mozilla/webtools/bugzilla/editproducts.cgi,v  <--  editproducts.cgi
new revision: 1.66; previous revision: 1.65
done
Checking in enter_bug.cgi;
/cvsroot/mozilla/webtools/bugzilla/enter_bug.cgi,v  <--  enter_bug.cgi
new revision: 1.102; previous revision: 1.101
done
Checking in globals.pl;
/cvsroot/mozilla/webtools/bugzilla/globals.pl,v  <--  globals.pl
new revision: 1.297; previous revision: 1.296
done
Checking in post_bug.cgi;
/cvsroot/mozilla/webtools/bugzilla/post_bug.cgi,v  <--  post_bug.cgi
new revision: 1.99; previous revision: 1.98
done
Checking in process_bug.cgi;
/cvsroot/mozilla/webtools/bugzilla/process_bug.cgi,v  <--  process_bug.cgi
new revision: 1.232; previous revision: 1.231
done
Checking in sanitycheck.cgi;
/cvsroot/mozilla/webtools/bugzilla/sanitycheck.cgi,v  <--  sanitycheck.cgi
new revision: 1.76; previous revision: 1.75
done
Checking in Bugzilla/Bug.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Bug.pm,v  <--  Bug.pm
new revision: 1.53; previous revision: 1.52
done
Checking in Bugzilla/BugMail.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/BugMail.pm,v  <--  BugMail.pm
new revision: 1.29; previous revision: 1.28
done

Comment 13

[Max Kanat-Alexander]

Added to the release notes in bug 286274.