276894 - "Website Certified by an Unknown Authority" dialog is too wide

Status: RESOLVED FIXED

(Core Graveyard :: Security: UI, defect)

Description

[Stefan Borggraefe]

This is a regression from bug 251991.

Steps to reproduce:
1. Go to the page https://ghost.anime.pl/~eyck/log/index.digitalPaper.html
2. Accept the first dialog (certificate expired warning) by pressing "Continue".
3. A second dialog pops up, warning about the certificate being certified by an
unknown authority.

Result:
The second dialog (newserver.xul) is too wide.

Comment 1

[Stefan Borggraefe]

Attachment: Patch

I compared the size I chose with the size of the same dialog in an 1.7-build.
They are roughly the same.

Comment 2

[[e-mail]]

Comment on attachment 170168 [details] [diff] [review]
Patch

Actually I backed out the latest changes to no effect, so I'm blaming some
other regression.

Comment 3

[Stefan Borggraefe]

Neil, do you have (like I had until now) the patch for Bug 274703 in your tree?
I tested revertig this patch and it seems it was causing the problem. :-(

Comment 4

[[e-mail]]

Aha, so what's going on here, is that the startup sets the third reason from a
formatted string. Then, it tried to size to content. However, because the
pending reflows weren't getting flushed, the window was still sizing to the
width of the first reason (which is the widest string defined in the XUL). With
properly flushed reflows the window now sizes to the width of the third reason.

Comment 5

[Boris Zbarsky [:bzbarsky]]

So the dialog used to line-wrap the reason, but now it's setting its size based
on the reason and the reason is ending up all on one line?

Comment 6

[[e-mail]]

(In reply to comment #5)
>So the dialog used to line-wrap the reason
Well, without the patch in bug 274703 the insertion of the text into the reason
does not fully flush, so that the size is calculated as if the text was not
there. Then when the dialog is shown it is too late the dynamic text is then
forced to flow to the width of the static text. (Don't ask me how the height is
sorted out, that's beyond me...)
With that patch the dialog correctly sizes to the dynamic text, thus requiring
the patch attached here. Accessing document.documentElement.boxObject.width (or
height) will also force the appropriate flush.

Comment 7

[Boris Zbarsky [:bzbarsky]]

OK.  I see.

Comment 8

[Stefan Borggraefe]

I wonder if it still makes sense to check the patch in. Currently the dialog
only gets a decent width "by accident" and it is not obvious why it gets it.

On the other hand I could as well just mark this bug as INVALID, because the
described regression doesn't exist (yet). When the patch for bug 274703 gets
checked in I could reopen this bug, check in the already reviewed patch and
resolve the bug as FIXED again. ;-)

Comment 9

[Stefan Borggraefe]

Since the patch for bug 274703 was checked in, I now also checked in this
regression fix. Marking FIXED.