Closed
Bug 277121
Opened 20 years ago
Closed 20 years ago
Remove printf on non DEBUG builds
Categories
(Core :: Printing: Output, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: pete, Assigned: pete)
References
()
Details
Attachments
(1 file)
|
687 bytes,
patch
|
benjamin
:
review+
bzbarsky
:
superreview+
|
Details | Diff | Splinter Review |
The lxr url posted above points to a stray printf which shouldn't be displayed in non debug builds. Patch forthcoming ...
| Assignee | ||
Comment 1•20 years ago
|
||
| Assignee | ||
Updated•20 years ago
|
Attachment #170351 -
Flags: superreview?
Attachment #170351 -
Flags: review?(bsmedberg)
| Assignee | ||
Updated•20 years ago
|
Assignee: core.printing → pete
| Assignee | ||
Updated•20 years ago
|
Status: NEW → ASSIGNED
Comment 2•20 years ago
|
||
Comment on attachment 170351 [details] [diff] [review] gfx/src/ps/nsAFMObject.cpp r=varga, it should pretty safe to remove this printf in non-debug builds :)
| Assignee | ||
Comment 3•20 years ago
|
||
Thanks Jan, any buddies who can super review this?
Updated•20 years ago
|
Attachment #170351 -
Flags: superreview?(bzbarsky)
Attachment #170351 -
Flags: superreview?
Attachment #170351 -
Flags: review?(bsmedberg)
Attachment #170351 -
Flags: review+
Comment 4•20 years ago
|
||
Comment on attachment 170351 [details] [diff] [review] gfx/src/ps/nsAFMObject.cpp sr=bzbarsky
Attachment #170351 -
Flags: superreview?(bzbarsky) → superreview+
| Assignee | ||
Comment 5•20 years ago
|
||
As soon as Myk updates my new id_dsa.pub, I'll check this in. Anyone else please feel free to check it in ...
| Assignee | ||
Comment 6•20 years ago
|
||
Checked in ... Thanks all
Comment 7•20 years ago
|
||
the tree is frozen currently, btw.
Comment 8•20 years ago
|
||
This is fixed, isn't it?
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
| Assignee | ||
Comment 9•20 years ago
|
||
Yup
| Assignee | ||
Comment 10•20 years ago
|
||
This patch needs to land on the branch, how do I do that?
You need to log in
before you can comment on or make changes to this bug.
Description
•