277189 - New filters (Create Filter from Message) lost when application closed.

Status: RESOLVED WORKSFORME

(Thunderbird :: General, defect)

Description

[Steven Boothe]

Summary just about says it all.

Strangely I am only able to retain the first seven filters I created. Now after
that I can't create any more filters and hope that they stick around until the
next time I run Thunderbird.

I have reproduced this twice in a row now.

I uninstalled the software. I also sanitized the registry and my personal data
files before reinstalling the software. The problem came back.

Now I am reporting the problem.

Comment 1

[OstGote!]

Did you close the filter dialog before you closed TB? Perhaps related to Bug 237470.

Comment 2

[Steven Boothe]

(In reply to comment #1)
> Did you close the filter dialog before you closed TB? Perhaps related to Bug
237470.

Here are the steps to reproduce the problem:

1. Start Thunderbird
2. Click on any email address in heading of msg window (eg. "From")
3. "create Filter from Message".
4. Select folder to move filtered results to.
5. Click "OK" (note: upon clicking "OK" the filters dialog closes too?)
6. Quit Thunderbird
7. Start Thunderbird
8. Open Message Filters

The filters previously entered are gone.

Note that I am using an IMAP account. Maybe that has something to do with it.
Also, I have noticed that 

Comment 3

[Jeroen van Baarsel]

(In reply to comment #2)

No, it has nothing to do with MAPI. I also have this problem, easy to 
reproduce following your steps, and I don't use MAPI.

I have an addition. If you, before closing TB (in step 6), open the Message 
filters, you'll see the newly created filter. If you click OK and close TB 
now, the filter will be saved. So, you'll have to OPEN the Message filters 
after you create filter with the "Create filter from message" function, or 
else the filters aren't saved!

Comment 4

[Mike Cowperthwaite]

I can confirm this.  If after you've created the filter and clicked OK, you then 
select  Tools | Message Filters  you will see the new filter in place -- and 
closing TB will not cause the filter to be lost.  So that's a workaround; but in 
essence, this *is* the same problem as bug 237470.

However: in the Suite, when you use Create Filter From Message, after the OK is 
clicked on the filter definition, the Message Filters dialog pops up to show the 
list of filters for the account -- so this problem does not occur there, only 
with Thunderbird.

Comment 5

[Tuukka Tolvanen (sp3000)]

*** Bug 274813 has been marked as a duplicate of this bug. ***

Comment 6

[Mike Cowperthwaite]

(In reply to comment #4)
> However: in the Suite, when you use Create Filter From Message, after the OK
> is clicked on the filter definition, the Message Filters dialog pops up to
> show the list of filters for the account -- so this problem does not occur
> there, only with Thunderbird.

I see this behavior has been fixed in TB trunk builds -- the Message 
Filters dialog appears after clicking OK on the Filter Rules dialog, with 
TB 1.0+0222, Win2K.

However, the bug is still present in today's Aviary build -- 1.0.1-0225.
It would be nice if the fix (if Scott knows where that came from) could be 
ported in, but there's probably not enough time for the 1.0.1 release.

Comment 7

[Scott MacGregor]

1.0.1 is for security only mike so we wouldn't be porting fixes like this to the
security respin. users will see the fix in 1.1

Comment 8

[Mike Cowperthwaite]

*** Bug 276509 has been marked as a duplicate of this bug. ***

Comment 9

[Mike Shaver (:shaver emeritus)]

Marking blocking+ based on Scott's comment 7.

Comment 10

[Mike Cowperthwaite]

Hm.  At the time I set the request flag, the "fix" was already in place in the 
trunk, so I shouldn't have set it -- maybe I thought I was requesting it for 
TB 1.0.1, I don't remember now.  At any rate: the behavior specific to Create 
Filter From Message no longer applies for the trunk (Moz 1.8, too), so I'm 
WFM'ing this bug.

The issue of bug 237470 is still extant, and can result in the same problem as 
this bug; but note that the reporter of that bug describes a patch he apparently 
made locally to fix it.

Comment 11

[Joseph Conner]

This issue is still active for me, although rare.  I have 60 filters set up. 
When attempting to set up #61, it has twice failed to record.

Comment 12

[Mike Cowperthwaite]

(In reply to comment #11)
> This issue is still active for me, although rare.  I have 60 filters set up. 
> When attempting to set up #61, it has twice failed to record.

Are you reporting something other than bug 237470?  If so, please provide a lot 
more detail.

Comment 13

[Geert Poels]

Apparently to fix this bug, a quick hack was introduced : just show the 'Message filters' dialog, right after the creation of a filter...
(see https://bugzilla.mozilla.org/show_bug.cgi?id=322451)

Comment 14

[Mike Cowperthwaite]

*** Bug 297787 has been marked as a duplicate of this bug. ***

Comment 15

[Mike Cowperthwaite]

(In reply to comment #13)
> Apparently to fix this bug, a quick hack was introduced : just show the
> 'Message filters' dialog, right after the creation of a filter...

I think it was a fix rather than a hack -- see bug 198597, where the current behavior is assumed as the basis of the RFE.  I guess that was broken at some point, which led to this bug being opened, and then fixed, which led to this bug being WFM'd.

Comment 16

[Geert Poels]

A fix ?
An dialog listing all message filters is required to persist the just created filter into a prefs file ?
Weird !