277242 - source file in wrong in "Failed to load overlay" error message

Status: NEW

(Core :: XUL, defect)

Description

[Henrik Gemal]

I'm getting:
Warning: Failed to load overlay from chrome://locale-switch/content/switch.xul.
Source File: chrome://browser/content/browser.xul
Line: 0

clicking on the source file link provides me with browser.xul while the
chrome://locale-switch/content/switch.xul is actually loaded from:

profilepath\chrome\overlayinfo\browser\content\overlays.rdf

Comment 1

[Benjamin Smedberg]

Getting the real source (which is actually a contents.rdf manifest, not the
overlays.rdf cache) is a difficult process, and you would still have to report
the source file which was being overlaid.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Hmm... I didn't realize we had ways to load overlays other than the xul-overlay
PI.  So the code just reports the document the overlay is being inserted into.

I suspect the overlay doesn't actually know what caused it to be inserted, so
fixing this, if desired, would take some surgery on the overlay mechanism.

Comment 3

[Henrik Gemal]

BTW: Shouldn't this be a error and not a warning?

http://lxr.mozilla.org/mozilla/source/content/xul/document/src/nsXULDocument.cpp#3007