277273 - Problem with html comments

Status: RESOLVED INVALID

(Core :: DOM: HTML Parser, defect)

Description

[Jesse Coddington]

According to the url, HTML comments can be as follows:

"A comment declaration starts with <!, followed by zero or more comments,
followed by >. A comment starts and ends with "--", and does not contain any
occurrence of "--"."

   1. <!-- Hello -->
   2. <!-- Hello -- -- Hello-->
   3. <!---->
   4. <!------ Hello -->
   5. <!> 

Looking at testcase 4, if you remove the space <!------Hello -->, the comment no
longer works as well as the testcase <!------ Hello -- >.  Both of these should
work but do not.

Comment 1

[Phil Ringnalda (:philor)]

All of those including your alterations wfm, 1.0 and trunk. Can you attach a
testcase that shows your nonworking comment situation?

Comment 2

[Jesse Coddington]

Attachment: Example of comments

Comment 3

[Jesse Coddington]

Comment on attachment 170469 [details]
Example of comments

It looks like the following:

<!-------- This is a test -->

Comment 4

[Ng Ming Hong]

How can case 2 and 4 be valid? There are occurrences of "--" between "<!--" and
"-->".

Comment 5

[Jesse Coddington]

I don't know about test case 2, but i'm assuming that with test case 4, the
reason it's valid is because there is no spacing in the dashes.

I'm seeing a lot of sites use comments like this and i think that it would help
the overall rendering of webpages if these were included.

Comment 6

[Christian :Biesinger (don't email me, ping me on IRC)]

        <![----][----] This is a test -->

I marked pairs of -- -- (start/end pairs) with []. as you can see, there is a
mismatch here - the final -- has no matching --. thus, this document is invalid.
html does not define error handling. this bug is invalid.

Comment 7

[Christian :Biesinger (don't email me, ping me on IRC)]

(note that in quirks mode, which the testcase attached here does not use,
comments are interpreted to start with <!-- and end with -->).