277321 - New option "Preserve threading when sorting messages" not documented in Help

Status: VERIFIED FIXED

(Documentation Graveyard :: Help Viewer, defect)

Description

[Stefan Borggraefe]

Bug 234690 added this new option to the FE. It still needs to be documented in Help.

Comment 1

[Stefan Borggraefe]

Attachment: Patch

Hopefully this is correct English. ;-)

Comment 2

[Ian Neal]

Comment on attachment 170500 [details] [diff] [review]
Patch

> <p><strong>Tip</strong>: The thread button automatically sorts the threads
> after the age of their parent messages. If you want to use another
This first sentence doesn't sound right - perhaps replace "after" with "by"

> sort criterion for the threads, open the View menu and select the desired
>-option from the Sort by submenu.</p>
>+option from the Sort by submenu. If you want to turn off the automatic
>+switch between threaded and unthreaded message grouping when sorting
>+messages, Select "Preserve threading when sorting messages" in the
>+<a href="#mail_and_newsgroups">Mail &amp; Newsgroups Preferences</a>.</p>
I think this new sentence is not clear enough in what is changed, I had to read
the later changes to understand its meaning. Possibly change it to be almost
identical to the later changes, for example:

Select "Preserve threading when sorting messages" in the 
<a href="#mail_and_newsgroups">Mail &amp; Newsgroups Preferences</a> 
if you want &brandShortName; to preserve the threaded
message grouping when sorting messages. If it is not selected, 
&brandShortName; automatically displays the messages unthreaded 
when you sort them.</p>

Comment 3

[[e-mail]]

Comment on attachment 170500 [details] [diff] [review]
Patch

It's not clear that the preference only applies to column header clicks. Maybe
you should split the first tip into two? Also I think you should note that with
simple columns the thread button toggles threading.

Comment 4

[Stefan Borggraefe]

Attachment: Patch V1.1

Better?

Comment 5

[Ian Neal]

Right patch on wrong bug?

Comment 6

[Stefan Borggraefe]

Attachment: Patch V1.1 (this time for real)

(In reply to comment #5)
> Right patch on wrong bug?

No, right bug wrong patch. ;-)

Comment 7

[[e-mail]]

Comment on attachment 170870 [details] [diff] [review]
Patch V1.1 (this time for real)

Oh, and file a bug "Bugzilla should not let me attach bug101874.diff to bug
277321" :-P

Comment 8

[Stefan Borggraefe]

(In reply to comment #7)
> (From update of attachment 170870 [details] [diff] [review] [edit])
> Oh, and file a bug "Bugzilla should not let me attach bug101874.diff to bug
> 277321" :-P

Or a bug "Stefan should buy a new mouse/pair of eyes so he clicks on the file he
means to upload." ;-)

Patch checked in.

Comment 9

[Stefan [:stefanh]]

Verified. But note that we're using <q>...</q> instead of "..." ;)