277329 - nsIMenu.h need not include nsIDocShell.h

Status: RESOLVED FIXED

(Core Graveyard :: GFX, defect)

Description

[Christian :Biesinger (don't email me, ping me on IRC)]

nsIDocShell is only used as an argument, as a pointer. hence, a forward
declaration should suffice:
  class nsIDocShell;

Comment 1

[Boris Zbarsky [:bzbarsky]]

biesi, is this just a one-line change?  Wanna post a patch?

Comment 2

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: patch

when I filed the bug, I weren't sure if other files depended on this file
including nsIDocShell.h

it seems no files do, at least on linux.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 172918 [details] [diff] [review]
patch

sr=bzbarsky if you do forward-declare nsIDocShell... (mac will need that, I'm
sure).

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 172918 [details] [diff] [review]
patch

what bz said

Comment 5

[Christian :Biesinger (don't email me, ping me on IRC)]

Checking in widget/public/nsIMenu.h;
/cvsroot/mozilla/widget/public/nsIMenu.h,v  <--  nsIMenu.h
new revision: 1.31; previous revision: 1.30
done

(with forward-declaration of nsIDocShell)