277389 - Flag notification code should NOT append emailsuffix to cc list's addresses

Status: RESOLVED FIXED

(Bugzilla :: Email Notifications, defect)

Description

[Marc Schumann [:Wurblzap]]

As stated in
http://www.bugzilla.org/docs/tip/html/flags-overview.html#flags-create-field-cclist,
a flag's cc list contains full e-mail addresses as opposed to Bugzilla logins.

I was not aware of that, so my patch on bug 256762 is wrong. It appends the
e-mail suffix to the cc lists' addresses (and not even in all cases as Peter
pointed out in bug 256762, comment 12) but needs to leave it alone instead.

Comment 1

[Marc Schumann [:Wurblzap]]

Attachment: Patch

Comment 2

[Marc Schumann [:Wurblzap]]

Attachment: Adding a comment to the flag admin page, too

Comment 3

[Christian Reis]

Comment on attachment 170537 [details] [diff] [review]
Adding a comment to the flag admin page, too

>--- head/template/en/default/admin/flag-type/edit.html.tmpl	2004-12-19 21:53:26.000000000 +0100
>+++ patched/template/en/default/admin/flag-type/edit.html.tmpl	2005-01-07 12:26:14.000000000 +0100
>@@ -163,7 +163,13 @@
>     <tr>
>       <th>CC List:</th>
>       <td>
>-        if requestable, who should get carbon copied on email notification of requests<br>
>+        if requestable, who should get carbon copied on email notification of requests;
>+        this is a comma-separated list of full e-mail addresses which do not
>+        need to be Bugzilla logins
>+        [% IF Param('emailsuffix') %],
>+          so please make sure to append your emailsuffix
>+          <kbd>[% Param('emailsuffix') %]</kbd> on each
>+        [% END %].<br>

I'd make this a separate sentence:

  Note that the configured emailsuffix 'mozilla.org' will *not* be appended to
these addresses, and you should add it explicitly if so desired.

r=kiko with that.

Comment 4

[Marc Schumann [:Wurblzap]]

Attachment: Patch 1.2

Addressing comments.

Comment 5

[Marc Schumann [:Wurblzap]]

Attachment: Patch 1.3

Uploaded the wrong file (an older one). Sorry.

Comment 6

[Vlad Dascalu]

Checking in Bugzilla/Flag.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Flag.pm,v  <--  Flag.pm
new revision: 1.27; previous revision: 1.26
done
Checking in template/en/default/admin/flag-type/edit.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/flag-type/edit.html.tmpl,v
 <--  edit.html.tmpl
new revision: 1.10; previous revision: 1.9
done

Comment 7

[Vlad Dascalu]

Checking in Bugzilla/Flag.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Flag.pm,v  <--  Flag.pm
new revision: 1.18.2.6; previous revision: 1.18.2.5
done
Checking in template/en/default/admin/flag-type/edit.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/flag-type/edit.html.tmpl,v
 <--  edit.html.tmpl
new revision: 1.6.2.3; previous revision: 1.6.2.2
done

Comment 8

[Peter Kay]

Ok, new problem:

<bright red>
The e-mail address you entered ([e-mail]) didn't pass our syntax checking
for a legal email address. Enter only the username (the @host.com will be
appended). It must also not contain any of these special characters: \ ( ) & < >
, ; : " [ ], or any whitespace.
</bright red>

in editflagtypes.cgi, sub validateCCList, there's the line:
    foreach my $address (@addresses) { CheckEmailSyntax($address) }
This of course checks it against the parameter "emailregexp"

If we allow arbitrary CC lists for Flags (why *do* we do that for flags but not
for normal CC lists?) then we will need a seperate way to validate the CC e-mail
addresses.

Comment 9

[Marc Schumann [:Wurblzap]]

(In reply to comment #8)

Whoa... You're right. Please do file a new bug on this.

Comment 10

[Peter Kay]

Added bug 278414