277417 - SQL error when reloading the page after changing the bug resolution to duplicate

Status: RESOLVED FIXED

(Bugzilla :: Creating/Changing Bugs, defect)

Description

[janez.trost]

Reproduce
1. Resolve bug as duplicate
2. Commit
3. On next page hit reload (on browser) - dont ask me why i did this;
4. On 'Mid-air collision' page save your changes anyway

You get this message:

Software error:
DBD::mysql::st execute failed: Duplicate entry '18' for key 1 [for Statement
"INSERT INTO duplicates VALUES (17, 18)"] at Bugzilla/DB.pm line 62
	Bugzilla::DB::SendSQL('INSERT INTO duplicates VALUES (17, 18)') called at
C:/Bugzilla/process_bug.cgi line 1760

Comment 1

[Frédéric Buclin]

*** Bug 297266 has been marked as a duplicate of this bug. ***

Comment 2

[Frédéric Buclin]

Attachment: patch, v1

Comment 3

[Dave Miller [:justdave]]

For the record, as un-nice as this is, it's not a regression, and it's also an
edge case, so it's not worth pushing for a stable branch.

This issue is a side effect of the more general problem of allowing the same
form to be submitted twice, although a specific test for "this bug is already a
duplicate of <foo>" might be a nice thing to have anyway.

Comment 4

[Frédéric Buclin]

Attachment: patch, v1.1

add a whitespace between 'bug' and its number.

Comment 5

[Teemu Mannermaa (:wicked)]

Comment on attachment 185866 [details] [diff] [review]
patch, v1.1

Tested and this seems to fix the error and report an user error instead. Normal
duplication and status changes seem to work.

I was thinking that maybe a mid-air collision would be better than an user
error. But maybe it's ok as I see there is already an user error reported when
duplicating to same bug number..

Only minor problem is with the title of the error message. "Duplication Entry
Found" just doesn't sound right. Perhaps use "Already marked as duplicate" or
something else. Also change word dupe in the error text to duplicate.

Comment 6

[Frédéric Buclin]

Attachment: patch, v2

happy now?

Comment 7

[Teemu Mannermaa (:wicked)]

Comment on attachment 185874 [details] [diff] [review]
patch, v2

No, but that's not because of your patch. It's good to go. r=wicked

Comment 8

[Frédéric Buclin]

Checking in process_bug.cgi;
/cvsroot/mozilla/webtools/bugzilla/process_bug.cgi,v  <--  process_bug.cgi
new revision: 1.258; previous revision: 1.257
done
Checking in template/en/default/global/user-error.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/global/user-error.html.tmpl,v
 <--  user-error.html.tmpl
new revision: 1.111; previous revision: 1.110
done

Comment 9

[Frédéric Buclin]

*** Bug 151129 has been marked as a duplicate of this bug. ***