277421 - Setting absolute position disables column layout [columns]

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Boris Zbarsky [:bzbarsky]]

The basic issue is that ConstructFrameByDisplayType has several branches, for
positioned blocks, for blocks with overflow set, etc.  Not all of these end up
calling into ConstructBlock, which is where columns are handled; in particular
the "positioned blocks" branch does not.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Testcase

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: fix

This fixes it by making absolute frame construction call ConstructBlock instead
of doing its own thing. A nice improvement.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 172320 [details] [diff] [review]
fix

Nice!  If I'd noticed it was already so much like ConstructBlock, I'd have
attached a patch when I filed... ;)


>Index: layout/base/nsCSSFrameConstructor.cpp
>+    rv = ConstructBlock(aPresShell, aPresContext, aState, aDisplay, aContent, 
>+                        aState.GetGeometricParent(aDisplay, aParentFrame), adjParentFrame,
>+                        aStyleContext, &newFrame, *frameItems, PR_TRUE);

Note that you'll need to merge this to tip.  There's no adjParentFrame and
*frameItems anymore as of today, just aParentFrame and aFrameItems; the
adjusting is now done outside this function.

>-    nsTableFrame* tableFrame = NS_REINTERPRET_CAST(nsTableFrame*, aParentFrame);

I think this line is also gone as of today... ;)

>@@ -12830,17 +12805,17 @@ nsCSSFrameConstructor::ConstructBlock(ns
>+                                      PRBool                   aPositionContainer)

Maybe aAbsPosContainer?

And also rename the arg in nsCSSFrameConstructor.h?

r+sr=bzbarsky with that.

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

(In reply to comment #3)
> >@@ -12830,17 +12805,17 @@ nsCSSFrameConstructor::ConstructBlock(ns
> >+                                      PRBool                  
aPositionContainer)
> 
> Maybe aAbsPosContainer?

OK

> And also rename the arg in nsCSSFrameConstructor.h?

OK

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

checked in

Comment 6

[Boris Zbarsky [:bzbarsky]]

*** Bug 272009 has been marked as a duplicate of this bug. ***