277467 - memory leak in nsilookandfeel::getmetric (missing CFRelease call)

Status: RESOLVED FIXED

(Core Graveyard :: Widget: Mac, defect, P2)

Description

[Asaf Romano (gone)]

Comment 1

[Asa Dotzler [:asa]]

Asaf, we probably want to get this in for 1.8a6, right? Time is short. Can you
get a patch together quickly?

Comment 2

[Asaf Romano (gone)]

It's that critical, but "OK".

Comment 3

[Asaf Romano (gone)]

Attachment: patch

Comment 4

[Asaf Romano (gone)]

for the record, here is the full context;

        CFPropertyListRef fullKeyboardAccessProperty;
        fullKeyboardAccessProperty = ::CFPreferencesCopyValue
(CFSTR("AppleKeyboardUIMode"),
                                                              
kCFPreferencesAnyApplication,
                                                              
kCFPreferencesCurrentUser,
                                                              
kCFPreferencesAnyHost);

        if (fullKeyboardAccessProperty) {
          PRInt32 fullKeyboardAccessPrefVal;
          ::CFNumberGetValue(fullKeyboardAccessProperty, kCFNumberIntType,
                             &fullKeyboardAccessPrefVal);

          if (fullKeyboardAccessPrefVal == 3) // "Full keyboard access" is on
            aMetric = 7; // everything that can be focused
          else
            aMetric = 1; // Textboxes

          ::CFRelease(fullKeyboardAccessProperty);
        }

Comment 5

[Asa Dotzler [:asa]]

Comment on attachment 170691 [details] [diff] [review]
patch

a=asa for checkin to 1.8a6 pending sr.

Comment 6

[Asaf Romano (gone)]

checked in by smontagu.