277520 - Lacking header-info in /dcc-chat view

Status: RESOLVED FIXED

(Other Applications :: ChatZilla, defect)

Description

[Jan Eri]

When I /dcc-chat with someone it says "URL x-irc-dcc-chat://undefined:48000",
"Connected to <unknown>" and "Conversation with (null) (null)" in the header

Using 0.9.67 with firefox 1.0 on Linux/386

Comment 1

[James Ross]

I got an IP in the URL here, but that was most likely because the other end
initiated, and I get " 	Conversation with (null) <unknown>" rather than (null)
(null), but it's certainly not working very well.

I think I'll need to try to fix the problem with the normal DCC status messages
that happens when you initiate, too.

Comment 2

[Rob Marshall [tH]]

Attachment: first attempt

- Changes the dcc-chat header to just include nick/ip/port, removing the link.
- Labels and disables the nick button for DCC views.
- Puts useful info in the window title for DCC views.

Comment 3

[James Ross]

Comment on attachment 214007 [details] [diff] [review]
first attempt

>       <div class="header" id="dcc-chat-container" hidden="true">
>-        <table class="h-table">
>+        <table class="h-table" ID="Table1">

Um, "don't do that" ;)

>           <tbody>
>             <tr>
>-              <td class="label" localize="output.url"></td>
>-              <td class="value crop-right" width="100%">
>-                <a id="dcc-chat-url-anchor" class="chatzilla-link"
>-                   href="irc://foo/bar">irc://foo/bar</a>
>-              </td>
>+              <td id="dcc-chat-title" colspan="4" localize="none"></td>
>               <td class="label" id="dcc-chat-remotestr-l" localize="output.to"></td>
>               <td class="value" id="dcc-chat-remotestr" localize="none"></td>
>             </tr>
>-            <tr>
>-              <td id="dcc-chat-title" colspan="4" localize="none"></td>
>-            </tr>

Why was this moved? And more importantly, why on the same line as the other info? What about a screenshot?

> msg.title.net.on   = User %S on ``%S'' (%S:%S)
> msg.title.net.off  = User %S, not connected to network ``%S''
> msg.title.nonick   = <unregistered-user>
> msg.title.no.topic = No Topic
> msg.title.no.mode  = No Mode
> msg.title.channel  = "%S on %S (%S): %S"
> msg.title.user     = Conversation with %S %S"
>+msg.title.dccchat  = DCC Conversation with %S"
>+msg.title.dccfile.send = "%S%% of “%S” sent to %S"
>+msg.title.dccfile.get  = "%S%% of “%S” received from %S"

Don't like the idea of using those Unicode characters here when we don't for any other title. Use `` and '' for now, and feel free to file a bug to replace all of those uses in our strings with the Unicode ones (and remove the mungers).

Comment 4

[Rob Marshall [tH]]

Attachment: patch the second

Comment 5

[James Ross]

Checked in --> FIXED