277587 - nsSecureBrowserUIImpl's nsUIContext interface requestor doesn't give access to the dom window

Status: RESOLVED FIXED

(Core Graveyard :: Security: UI, defect)

Description

[Christian Persch (GNOME) (away; not receiving bug mail)]

nsSecureBrowserUIImpl calls nsISecurityWarningDialogs with a
nsIInterfaceRequestor which is gives out only nsIPrompt. The PSM default
nsSecurityWarningDialogs implementation only needs the nsIPrompt; but I want to
provide my own implementation of nsISecurityWarningDialogs and need to access
the nsIDOMWindow to have a parent for my dialogues (I can get from nsIDOMWindow
to the toplevel GtkWindow).

Comment 1

[Christian Persch (GNOME) (away; not receiving bug mail)]

Attachment: make the interface requestor give out its nsIDOMWindow

Comment 2

[Christian Persch (GNOME) (away; not receiving bug mail)]

Comment on attachment 170696 [details] [diff] [review]
make the interface requestor give out its nsIDOMWindow

Asking for review...

Comment 3

[John G. Myers]

Comment on attachment 170696 [details] [diff] [review]
make the interface requestor give out its nsIDOMWindow

You might want to just NS_ADDREF(mWindow) in order to avoid the cast.

Comment 4

[Christian Persch (GNOME) (away; not receiving bug mail)]

NS_ADDREF(mWindow) doesn't work since mWindow is a nsCOMPtr and ::AddRef is private.

Can you suggest who I should ask for super-review?

Comment 5

[Christian Persch (GNOME) (away; not receiving bug mail)]

Comment on attachment 170696 [details] [diff] [review]
make the interface requestor give out its nsIDOMWindow

Asking for superreview now...

Comment 6

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 170696 [details] [diff] [review]
make the interface requestor give out its nsIDOMWindow

we should land this no-risk patch for embedders

Comment 7

[Christian :Biesinger (don't email me, ping me on IRC)]

HEAD:
Checking in security/manager/boot/src/nsSecureBrowserUIImpl.cpp;
/cvsroot/mozilla/security/manager/boot/src/nsSecureBrowserUIImpl.cpp,v  <-- 
nsSecureBrowserUIImpl.cpp
new revision: 1.49; previous revision: 1.48
done

MOZILLA_1_8_BRANCH:
Checking in security/manager/boot/src/nsSecureBrowserUIImpl.cpp;
/cvsroot/mozilla/security/manager/boot/src/nsSecureBrowserUIImpl.cpp,v  <-- 
nsSecureBrowserUIImpl.cpp
new revision: 1.48.2.1; previous revision: 1.48
done

Comment 8

[Simon Fraser [no longer active]]

See also bug 306288. How much of it does this fix?

Please be more liberal with the Cc: list in future. Other people need to know what's going on.