If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

nsSecureBrowserUIImpl's nsUIContext interface requestor doesn't give access to the dom window

RESOLVED FIXED

Status

Core Graveyard
Security: UI
RESOLVED FIXED
13 years ago
a year ago

People

(Reporter: Christian Persch (GNOME) (away; not receiving bug mail), Assigned: John G. Myers)

Tracking

({fixed1.8})

Other Branch
x86
Linux
fixed1.8

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

nsSecureBrowserUIImpl calls nsISecurityWarningDialogs with a
nsIInterfaceRequestor which is gives out only nsIPrompt. The PSM default
nsSecurityWarningDialogs implementation only needs the nsIPrompt; but I want to
provide my own implementation of nsISecurityWarningDialogs and need to access
the nsIDOMWindow to have a parent for my dialogues (I can get from nsIDOMWindow
to the toplevel GtkWindow).
Created attachment 170696 [details] [diff] [review]
make the interface requestor give out its nsIDOMWindow
Comment on attachment 170696 [details] [diff] [review]
make the interface requestor give out its nsIDOMWindow

Asking for review...
Attachment #170696 - Flags: review?(jgmyers)
(Assignee)

Comment 3

13 years ago
Comment on attachment 170696 [details] [diff] [review]
make the interface requestor give out its nsIDOMWindow

You might want to just NS_ADDREF(mWindow) in order to avoid the cast.
Attachment #170696 - Flags: review?(jgmyers) → review+
(Assignee)

Updated

13 years ago
Assignee: kaie → jgmyers
Status: UNCONFIRMED → NEW
Ever confirmed: true
NS_ADDREF(mWindow) doesn't work since mWindow is a nsCOMPtr and ::AddRef is private.

Can you suggest who I should ask for super-review?

Updated

13 years ago
Component: Security: UI → Security: UI
Product: PSM → Core
Comment on attachment 170696 [details] [diff] [review]
make the interface requestor give out its nsIDOMWindow

Asking for superreview now...
Attachment #170696 - Flags: superreview?(alecf)
Comment on attachment 170696 [details] [diff] [review]
make the interface requestor give out its nsIDOMWindow

we should land this no-risk patch for embedders
Attachment #170696 - Flags: superreview?(alecf)
Attachment #170696 - Flags: superreview+
Attachment #170696 - Flags: approval1.8b4?

Updated

12 years ago
Attachment #170696 - Flags: approval1.8b4? → approval1.8b4+
HEAD:
Checking in security/manager/boot/src/nsSecureBrowserUIImpl.cpp;
/cvsroot/mozilla/security/manager/boot/src/nsSecureBrowserUIImpl.cpp,v  <-- 
nsSecureBrowserUIImpl.cpp
new revision: 1.49; previous revision: 1.48
done

MOZILLA_1_8_BRANCH:
Checking in security/manager/boot/src/nsSecureBrowserUIImpl.cpp;
/cvsroot/mozilla/security/manager/boot/src/nsSecureBrowserUIImpl.cpp,v  <-- 
nsSecureBrowserUIImpl.cpp
new revision: 1.48.2.1; previous revision: 1.48
done
Status: NEW → RESOLVED
Last Resolved: 12 years ago
Keywords: fixed1.8
Resolution: --- → FIXED

Comment 8

12 years ago
See also bug 306288. How much of it does this fix?

Please be more liberal with the Cc: list in future. Other people need to know what's going on.
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.