Closed Bug 277603 Opened 20 years ago Closed 20 years ago

if sidebar is closed, opening a sidebar bookmark loads the previous bookmark instead

Categories

(Firefox :: Bookmarks & History, defect)

defect
Not set
minor

Tracking

()

RESOLVED FIXED

People

(Reporter: mconnor, Assigned: mconnor)

Details

(Keywords: regression)

Attachments

(1 file)

Basically, we're dying on the following code because at the time of the call, sidebar.docShell isn't in existence yet. var sidebar = document.getElementById("sidebar"); if (sidebar.docShell && sidebar.contentDocument && sidebar.contentDocument.getElementById('web-panels-browser')) { adding a check for docShell triggers the listener for the load event instead and we're fine.
Attached patch patchSplinter Review
Checking in mozilla/browser/base/content/browser.js; /cvsroot/mozilla/browser/base/content/browser.js,v <-- browser.js new revision: 1.362; previous revision: 1.361 done
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
sorry for bugspam, long-overdue mass reassign of ancient QA contact bugs, filter on "beltznerLovesGoats" to get rid of this mass change
QA Contact: mconnor → bookmarks
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: